Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom name for ratelimit deployment #4094

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Aug 21, 2024

* should have been part of envoyproxy#3537

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner August 21, 2024 23:46
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.94%. Comparing base (0926b38) to head (f9d26f2).
Report is 1 commits behind head on main.

Files Patch % Lines
...tructure/kubernetes/ratelimit/resource_provider.go 25.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4094      +/-   ##
==========================================
+ Coverage   67.92%   67.94%   +0.01%     
==========================================
  Files         187      187              
  Lines       23032    23035       +3     
==========================================
+ Hits        15644    15650       +6     
+ Misses       6271     6268       -3     
  Partials     1117     1117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg arkodg requested review from a team August 22, 2024 00:01
@shawnh2 shawnh2 merged commit 2c54de2 into envoyproxy:main Aug 22, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants