Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a jwks public private key pair for testing #4200

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Sep 10, 2024

This PR adds a jwks public private key pair for testing.

Currently, we can't generate a new JWT token as we don't have the private key of the existing JWKS.

This is required by #4167

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing requested a review from a team as a code owner September 10, 2024 04:00
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.97%. Comparing base (61dcc64) to head (3986244).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4200      +/-   ##
==========================================
- Coverage   68.00%   67.97%   -0.04%     
==========================================
  Files         190      190              
  Lines       23116    23116              
==========================================
- Hits        15720    15713       -7     
- Misses       6277     6282       +5     
- Partials     1119     1121       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg arkodg requested review from a team September 10, 2024 22:17
@zirain zirain merged commit 8e18b61 into envoyproxy:main Sep 10, 2024
24 checks passed
ncsham pushed a commit to ncsham/gateway that referenced this pull request Sep 11, 2024
* add a jwks public private key pair for testing

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* minor woriding

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: NCSham <sudoer@ncsham.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants