-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add gatewayapi/resource pkg #4235
Conversation
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4235 +/- ##
==========================================
- Coverage 66.50% 65.65% -0.86%
==========================================
Files 195 196 +1
Lines 23732 23538 -194
==========================================
- Hits 15783 15453 -330
- Misses 6831 6976 +145
+ Partials 1118 1109 -9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
/retest |
What type of PR is this?
What this PR does / why we need it:
gatewayapi/resource.go
intogatewayapi/resource/*
gatewayapi/translator.go's kind
intogatewayapi/resource/*
kubernetesYAMLToResources
func intogatewayapi/resource/*
Which issue(s) this PR fixes:
This is a refactor PR before implementing #1295, and it's very likely to get conflicts, so should be reviewed ASAP.