Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add gatewayapi/resource pkg #4235

Merged
merged 3 commits into from
Sep 14, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Sep 13, 2024

What type of PR is this?

What this PR does / why we need it:

  • move gatewayapi/resource.go into gatewayapi/resource/*
  • move gatewayapi/translator.go's kind into gatewayapi/resource/*
  • move shared kubernetesYAMLToResources func into gatewayapi/resource/*

Which issue(s) this PR fixes:

This is a refactor PR before implementing #1295, and it's very likely to get conflicts, so should be reviewed ASAP.

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner September 13, 2024 14:59
@shawnh2 shawnh2 changed the title Refactor resource refactor: add gatewayapi/resource pkg Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 26.16984% with 426 lines in your changes missing coverage. Please review.

Project coverage is 65.65%. Comparing base (14f687f) to head (bb107ef).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/resource/load.go 0.00% 333 Missing ⚠️
internal/provider/kubernetes/controller.go 38.46% 24 Missing ⚠️
internal/cmd/egctl/status.go 0.00% 13 Missing ⚠️
internal/provider/kubernetes/routes.go 0.00% 12 Missing ⚠️
internal/provider/kubernetes/status_updater.go 14.28% 12 Missing ⚠️
internal/gatewayapi/validate.go 72.00% 3 Missing and 4 partials ⚠️
internal/provider/file/resources.go 0.00% 6 Missing ⚠️
internal/provider/file/store.go 0.00% 5 Missing ⚠️
internal/provider/kubernetes/helpers.go 0.00% 3 Missing ⚠️
internal/provider/kubernetes/indexers.go 83.33% 3 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4235      +/-   ##
==========================================
- Coverage   66.50%   65.65%   -0.86%     
==========================================
  Files         195      196       +1     
  Lines       23732    23538     -194     
==========================================
- Hits        15783    15453     -330     
- Misses       6831     6976     +145     
+ Partials     1118     1109       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@arkodg arkodg requested review from a team September 13, 2024 23:15
@zirain
Copy link
Contributor

zirain commented Sep 13, 2024

/retest

@arkodg arkodg merged commit 3567496 into envoyproxy:main Sep 14, 2024
22 of 24 checks passed
@shawnh2 shawnh2 deleted the refactor-resource branch September 14, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants