Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable local validations for egctl translate and file provider #4257

Merged
merged 20 commits into from
Sep 29, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Sep 16, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1295, ref #2028

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
…pe-meta

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 51.81818% with 53 lines in your changes missing coverage. Please review.

Project coverage is 66.01%. Comparing base (3b9ab70) to head (414df60).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/resource/load.go 14.89% 38 Missing and 2 partials ⚠️
internal/cmd/egctl/validate.go 76.47% 4 Missing and 4 partials ⚠️
internal/gatewayapi/resource/validator.go 60.00% 2 Missing ⚠️
internal/cmd/egctl/experimental.go 0.00% 1 Missing ⚠️
internal/gatewayapi/resource/fs.go 95.23% 1 Missing ⚠️
internal/provider/file/resources.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4257      +/-   ##
==========================================
+ Coverage   65.98%   66.01%   +0.02%     
==========================================
  Files         197      200       +3     
  Lines       23972    24052      +80     
==========================================
+ Hits        15818    15878      +60     
- Misses       7027     7041      +14     
- Partials     1127     1133       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 marked this pull request as ready for review September 18, 2024 16:49
@shawnh2 shawnh2 requested a review from a team as a code owner September 18, 2024 16:49
@shawnh2 shawnh2 requested review from arkodg and a team September 23, 2024 15:18
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
tools/make/kube.mk Outdated Show resolved Hide resolved
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !
this is a really neat feature

@arkodg arkodg requested review from a team September 27, 2024 16:16
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Xunzhuo Xunzhuo merged commit b91f296 into envoyproxy:main Sep 29, 2024
10 checks passed
@shawnh2 shawnh2 deleted the local-validation branch September 29, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Gateway API webhook validation functions to egctl translate
3 participants