feat: implement fallback for the Backend API #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to envoyproxy#3055 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4461 +/- ##
==========================================
+ Coverage 65.82% 65.84% +0.02%
==========================================
Files 200 200
Lines 24278 24282 +4
==========================================
+ Hits 15980 15988 +8
+ Misses 7158 7156 -2
+ Partials 1140 1138 -2 ☔ View full report in Codecov by Sentry. |
zhaohuabing
approved these changes
Oct 17, 2024
zhaohuabing
reviewed
Oct 17, 2024
| @@ -131,7 +131,6 @@ type BackendSpec struct { | |||
| // the health of the active backends falls below 72%. | |||
| // | |||
| // +optional | |||
| // +notImplementedHide | |||
There was a problem hiding this comment.
Nit: a link to https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/priority#arch-overview-load-balancing-priority-levels will help users to better understand how fallback works.
There was a problem hiding this comment.
we dont want to expose the internal details, only want to represent it as a boolean field
zirain
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3055