api: ext-proc attributes #4747
Closed
api: ext-proc attributes #4747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guy Daich <guy.daich@sap.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4747 +/- ##
=======================================
Coverage 65.60% 65.60%
=======================================
Files 211 211
Lines 31961 31989 +28
=======================================
+ Hits 20968 20987 +19
- Misses 9753 9762 +9
Partials 1240 1240 ☔ View full report in Codecov by Sentry. |
zirain
reviewed
Nov 20, 2024
Comment on lines
+81
to
+89
| // MetadataOptions defines options related to the sending and receiving of dynamic metadata. | ||
| // These options define which metadata namespaces would be sent to the processor and which dynamic metadata | ||
| // namespaces the processor would be permitted to emit metadata to. | ||
| // Users can specify custom namespaces or well-known envoy metadata namespace (such as envoy.filters.http.ext_authz) | ||
| // documented here: https://www.envoyproxy.io/docs/envoy/latest/configuration/advanced/well_known_dynamic_metadata#well-known-dynamic-metadata | ||
| // Default: no metadata context is sent or received from the external processor | ||
| // | ||
| // +optional | ||
| MetadataOptions *ExtProcMetadataOptions `json:"metadataOptions,omitempty"` |
zirain
previously approved these changes
Nov 20, 2024
|
@guydc Can we add a short description to the release note? Or you pland to modify the release not in the implementation PR? |
Signed-off-by: Guy Daich <guy.daich@sap.com>
added |
zirain
previously approved these changes
Nov 27, 2024
* use Cluster_V4_PREFERRED Signed-off-by: zirain <zirain2009@gmail.com> * release notes Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com>
* [docs] Add Teleport as an Adopter Signed-off-by: Arko Dasgupta <arko@tetrate.io> * Update site/data/adopters.yaml Co-authored-by: David Boslee <dboslee@gmail.com> Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com> --------- Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com> Co-authored-by: David Boslee <dboslee@gmail.com>
Signed-off-by: bitliu <bitliu@tencent.com>
…gh Pod churn (envoyproxy#4754) * Revert "fix: some status updates are discarded by the status updater (envoyproxy#4337)" This reverts commit 14830c7. Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * store update events and process it later Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * rename method Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * add release note Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: bitliu <bitliu@tencent.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc
force-pushed
the
extproc-metadata-attrs
branch
from
7e1b44c to
4d2d71e
Compare
|
closed in favor of: #4794 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Following the discussion at KubeCon NA : https://docs.google.com/document/d/1PS5xLA0IDbj6McHIXXhShn51Zq37WvuistaidBPeHoE/edit?tab=t.0
Scope and Motivation
This API will allow users to define which attributes are sent to the external processor as context for requests/responses.
Attributes provide HTTP extensions with additional context (e.g. TCP, TLS and XDS attributes) that can be relevant inputs for the extension logic.
Comparison to other extension options
Many Envoy extensions are inherently capable of interaction with context attributes:
For out-of-process extensions like ext-proc, Envoy must be explicitly configured to allow access to attributes and and define the scope of access. With the increase in ext-proc use cases, such as the llm-instance-gateway, envoy-ai-gateway and externally-deployed WAFs, there is a greater need to provide Connection/Stream context.
Security Considerations
Most attributes are scoped to the current connection or stream by their prefix (
connection.*,request.*,response.*), with the exception ofxds.*attributes such asxds.listener_metadata,xds.upstream_host_metadata,xds.nodeand generic metadata and filter state access attributes.Related Work
Untypedmetadata support in ExtProc #4160Release Notes: Yes