fix: decouple gateway status updates from the reconciler #4767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
changed the title
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
zhaohuabing
force-pushed
the
fix-gateway-status-blocking
branch
from
1797785 to
8c84649
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4767 +/- ##
==========================================
+ Coverage 66.24% 66.31% +0.06%
==========================================
Files 209 209
Lines 31922 31950 +28
==========================================
+ Hits 21148 21188 +40
+ Misses 9523 9512 -11
+ Partials 1251 1250 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
zhaohuabing
changed the title
arkodg
reviewed
Nov 22, 2024
|
were we deadlocking ? |
arkodg
reviewed
Nov 22, 2024
zhaohuabing
force-pushed
the
fix-gateway-status-blocking
branch
from
2b2535b to
8323c0f
Compare
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
zhaohuabing
force-pushed
the
fix-gateway-status-blocking
branch
2 times, most recently
from
91fe885 to
bb391aa
Compare
zhaohuabing
force-pushed
the
fix-gateway-status-blocking
branch
from
bb391aa to
7a4c51e
Compare
zhaohuabing
force-pushed
the
fix-gateway-status-blocking
branch
from
d948846 to
0a1f8f2
Compare
zhaohuabing
force-pushed
the
fix-gateway-status-blocking
branch
from
0a1f8f2 to
e406088
Compare
zhaohuabing
commented
Nov 24, 2024
arkodg
reviewed
Nov 25, 2024
arkodg
reviewed
Nov 25, 2024
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
arkodg
reviewed
Dec 11, 2024
arkodg
changed the title
zhaohuabing
added a commit
to zhaohuabing/gateway
that referenced
this pull request
Dec 12, 2024
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
zirain
reviewed
Dec 12, 2024
| @@ -37,19 +38,22 @@ type Server struct { | |||
| // Logger is the logr implementation used by Envoy Gateway. | |||
| Logger logging.Logger | |||
| // Elected chan is used to signal what a leader is elected | |||
| Elected chan struct{} | |||
| Elected *sync.WaitGroup | |||
There was a problem hiding this comment.
why we need a pointer here?
There was a problem hiding this comment.
internal/infrastructure/runner/runner.go:35:25: copylocks: literal copies lock value from *cfg: github.com/envoyproxy/gateway/internal/infrastructure/runner.Config contains github.com/envoyproxy/gateway/internal/envoygateway/config.Server contains sync.WaitGroup contains sync.noCopy (govet)
return &Runner{Config: *cfg}
|
Verified with #4904. |
guydc
approved these changes
Dec 12, 2024
guydc
approved these changes
Dec 12, 2024
zhaohuabing
added a commit
to zhaohuabing/gateway
that referenced
this pull request
Dec 13, 2024
…4767) * decoup gateway status update Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * decoup gatewayclass status update Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix test Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * add comment Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix test Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix test Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * revert gateway api runner Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * update address and programming status Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * Revert "update address and programming status" This reverts commit bf3d07e. * avoid overriding the gateway status from Gateway API translator Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * minor wording Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * minor wording Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * only subscribe to status updates upon acquiring leadership Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix lint Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * minor wording Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * address comment Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * address comment Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * minor wording Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix lint Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * minor change Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * release note Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> (cherry picked from commit c1ff135) Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4845
Release Note: Yes