Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: add tencent cloud as an adopter #4786

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Nov 27, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Release Notes: No

Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo requested a review from a team as a code owner November 27, 2024 02:38
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team and arkodg November 27, 2024 02:40
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @Xunzhuo for making this happen!

@@ -43,6 +45,7 @@ If you would like to be included in this table, please submit a PR to this file
* (Option) Description:

## Airspace Link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we delete the content here and only maintain site/data/adopters.yaml ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkodg arkodg merged commit cda2dcb into envoyproxy:main Nov 27, 2024
19 checks passed
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.61%. Comparing base (29b5eaa) to head (cc7d33f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4786   +/-   ##
=======================================
  Coverage   65.61%   65.61%           
=======================================
  Files         211      211           
  Lines       31961    31961           
=======================================
+ Hits        20970    20971    +1     
+ Misses       9751     9750    -1     
  Partials     1240     1240           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

guydc pushed a commit to guydc/gateway that referenced this pull request Nov 27, 2024
Signed-off-by: bitliu <bitliu@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants