Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a waitGroup instead of an enabled channel in the status updater #4809

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Nov 28, 2024

  • use a waitGroup to synchronize to the Send method that the status updater is enabled and ready for updates

* use a waitGroup to synchronize to the `Send` method that the
status updater is enabled and ready for updates

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner November 28, 2024 17:21
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.65%. Comparing base (17e932c) to head (9600295).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4809      +/-   ##
==========================================
+ Coverage   65.59%   65.65%   +0.05%     
==========================================
  Files         211      211              
  Lines       32001    31983      -18     
==========================================
+ Hits        20992    20999       +7     
+ Misses       9767     9747      -20     
+ Partials     1242     1237       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg arkodg changed the title use a waitGroup instead of a channel in the status updater use a waitGroup instead of an enabled channel in the status updater Nov 28, 2024
@zirain zirain merged commit 36939dc into envoyproxy:main Nov 29, 2024
24 checks passed
@arkodg arkodg deleted the use-waitgroup-to-sync branch November 29, 2024 04:55
zhaohuabing pushed a commit to zhaohuabing/gateway that referenced this pull request Nov 29, 2024
…nvoyproxy#4809)

use a waitGroup instead of a channel in the status updater

* use a waitGroup to synchronize to the `Send` method that the
status updater is enabled and ready for updates

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 36939dc)
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
zhaohuabing pushed a commit to zhaohuabing/gateway that referenced this pull request Nov 29, 2024
…nvoyproxy#4809)

use a waitGroup instead of a channel in the status updater

* use a waitGroup to synchronize to the `Send` method that the
status updater is enabled and ready for updates

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 36939dc)
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
zhaohuabing added a commit that referenced this pull request Nov 29, 2024
* use a waitGroup instead of an enabled channel in the status updater (#4809)

use a waitGroup instead of a channel in the status updater

* use a waitGroup to synchronize to the `Send` method that the
status updater is enabled and ready for updates

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 36939dc)
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* fix: remove the default retry policy for jwks fetch (#4802)

* remove the default retry policy for jwks fetch

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* fix gen

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* Update release-notes/current.yaml

Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
(cherry picked from commit 526a05f)
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants