Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix license scan #4887

Merged
merged 1 commit into from
Dec 11, 2024
Merged

ci: fix license scan #4887

merged 1 commit into from
Dec 11, 2024

Conversation

shahar-h
Copy link
Contributor

What this PR does / why we need it:
Fix license scan by overriding unidentified license of github.com/golang/groupcache. Also opened an issue in deps.dev.

Release Notes: No

Signed-off-by: shahar-h <shahar.harari@sap.com>
@shahar-h shahar-h requested a review from a team as a code owner December 10, 2024 20:41
@arkodg arkodg requested review from a team December 10, 2024 20:45
@shahar-h
Copy link
Contributor Author

Still fails with:
Failed to run code analysis (govulncheck) on '/github/workspace/go.mod' because govulncheck: loading packages: err: exit status 1: stderr: go: go.mod requires go >= 1.23.3 (running go 1.22.7; GOTOOLCHAIN=local)

I'm looking into it.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.29%. Comparing base (0898544) to head (95f9e3b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4887      +/-   ##
==========================================
- Coverage   66.31%   66.29%   -0.02%     
==========================================
  Files         209      209              
  Lines       31955    31955              
==========================================
- Hits        21190    21186       -4     
- Misses       9518     9521       +3     
- Partials     1247     1248       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing
Copy link
Member

@shahar-h Could you please help me understand why osv scanner report unknown licensece for github.com/golang/groupcache 0.0.0-20241129210726-2c02b8208cf8 ? This version is on this page: https://pkg.go.dev/github.com/golang/groupcache?tab=versions

@zirain zirain merged commit 566b834 into envoyproxy:main Dec 11, 2024
23 of 24 checks passed
@shahar-h shahar-h deleted the patch-1 branch December 11, 2024 04:30
@shahar-h
Copy link
Contributor Author

@shahar-h Could you please help me understand why osv scanner report unknown licensece for github.com/golang/groupcache 0.0.0-20241129210726-2c02b8208cf8 ? This version is on this page: https://pkg.go.dev/github.com/golang/groupcache?tab=versions

licensing information is fetched from deps.dev, and this version is missing there. I opened an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants