Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for overriding status code in response overrides #4900

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Dec 12, 2024

Fixes: #4678

Fixes: envoyproxy#4678

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner December 12, 2024 00:54
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.31%. Comparing base (7bb7624) to head (d8f7832).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/filters.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4900      +/-   ##
==========================================
+ Coverage   66.25%   66.31%   +0.05%     
==========================================
  Files         209      209              
  Lines       31922    31948      +26     
==========================================
+ Hits        21150    21185      +35     
+ Misses       9522     9512      -10     
- Partials     1250     1251       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg marked this pull request as draft December 14, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deny-all SecurityPolicy can return 403 or 404, depending on HTTPRoutes
1 participant