Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update roadmap for v0.3.0 #695

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Update roadmap for v0.3.0 #695

merged 3 commits into from
Nov 9, 2022

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Nov 3, 2022

Signed-off-by: Arko Dasgupta arko@tetrate.io

@arkodg
Update roadmap for v0.3.0
0b41da1 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner November 3, 2022 22:30
@arkodg arkodg requested review from danehans and LukeShu and removed request for LukeShu and danehans November 3, 2022 22:30
@arkodg
Copy link
Contributor Author

arkodg commented Nov 3, 2022

ptal @danehans @LukeShu @AliceProxy @Xunzhuo @skriss @youngnick

Alice-Lilith
Alice-Lilith previously approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@Alice-Lilith Alice-Lilith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

Xunzhuo
Xunzhuo previously approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

danehans
danehans suggested changes Nov 4, 2022
View reviewed changes
docs/latest/design/roadmap.md Outdated
Comment on lines 37 to 40
- Support extended Gateway API fields.
- Support experimental Gateway APIs such as TCPRoute [Issue #643][643], UDPRoute [Issue #641][641] and GRPCRoute [Issue #642][642].
- Rate Limiting [Issue #670][670].
- Authentication [Issue #336][336].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this is overpromising. I would like to understand which maintainers will support these features. We should not depend on the community to deliver roadmap features. I'm in the process of updating #336, but this only covers the AuthN design. From recent feedback (#675 #677) and past experience, the AuthN design alone will take time. Since AuthN is laying the foundation for our approach to Gateway API extensions, this may cause a delay in starting #670. What was the conclusion for delaying RL for RLQS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danehans I assigned #670 to myself, I can design many aspects of it while waiting on the extension decision.
reg RLQS

  • we dont have any info on when it will release
  • will it be a better fit than Envoy's native RLS for the Gateway case ?
  • will it be more stable ?
    so will start the initial design with Envoy RLS, and can raise a follow up issue to consider moving to RLQS when we
    have enough data to answer above questions

docs/latest/design/roadmap.md
### [v0.4.0][v0.4.0]: Manageability and Scale
### [v0.4.0][v0.4.0]: More Advanced Features through Extension Mechanisms

- Allow users to configure xDS Resources [Issue #24][24].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest moving some of the v0.3 deliverables to v0.4. Note that the original v0.3 deliverables were based on a 6-month release cycle.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my concern too.

@arkodg arkodg requested a review from danehans November 4, 2022 16:24
skriss
skriss previously approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion, but LGTM overall

docs/latest/design/roadmap.md Outdated Show resolved Hide resolved
@arkodg
address skriss's comment
e824506 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg dismissed stale reviews from skriss, Xunzhuo, and Alice-Lilith via e824506 November 4, 2022 19:26
@arkodg arkodg requested review from skriss, Xunzhuo and Alice-Lilith and removed request for Alice-Lilith November 4, 2022 19:26
@arkodg
add link for extended fields in gateway api
69733de 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested review from Xunzhuo and Alice-Lilith and removed request for Alice-Lilith November 7, 2022 20:01
@danehans
Copy link
Contributor

danehans commented Nov 7, 2022

Codecov upload failure, rerunning CI.

@codecov-commenter
Copy link

Codecov Report

Merging #695 (69733de) into main (c147218) will decrease coverage by 0.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
- Coverage   63.59%   63.14%   -0.46%     
==========================================
  Files          47       47              
  Lines        5749     5806      +57     
==========================================
+ Hits         3656     3666      +10     
- Misses       1867     1909      +42     
- Partials      226      231       +5
Impacted Files Coverage Δ
internal/provider/kubernetes/helpers.go 73.91% <0.00%> (-6.53%) ⬇️
internal/ir/xds.go 77.82% <0.00%> (-4.68%) ⬇️
internal/provider/kubernetes/gateway.go 49.68% <0.00%> (-1.71%) ⬇️
internal/ir/zz_generated.deepcopy.go 19.09% <0.00%> (-1.48%) ⬇️
internal/provider/kubernetes/gatewayclass.go 73.18% <0.00%> (+0.72%) ⬆️
internal/provider/kubernetes/tlsroute.go 62.11% <0.00%> (+2.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Xunzhuo
Xunzhuo reviewed Nov 8, 2022
View reviewed changes
Copy link
Member

@Xunzhuo Xunzhuo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#657 #656 #564

BTW, need we add these three high-priority filters implementations into roadmap?

@arkodg
Copy link
Contributor Author

arkodg commented Nov 8, 2022

#656

@Xunzhuo these have been updated in the top level epic #707

@arkodg arkodg requested review from danehans, Alice-Lilith and Xunzhuo and removed request for Alice-Lilith November 8, 2022 18:01
Xunzhuo
Xunzhuo approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

danehans
danehans approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@danehans danehans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since a majority of maintainers have approved, I will not block. I am concerned that we are overcommitted for v0.3 but we can update the roadmap if needed.

@arkodg arkodg merged commit 9eecce6 into envoyproxy:main Nov 9, 2022
@arkodg arkodg deleted the roadmap-v0.3.0 branch November 9, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xunzhuo Xunzhuo Xunzhuo approved these changes

@danehans danehans danehans approved these changes

@skriss skriss Awaiting requested review from skriss

@Alice-Lilith Alice-Lilith Awaiting requested review from Alice-Lilith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arkodg @danehans @codecov-commenter @skriss @Alice-Lilith @Xunzhuo