Skip to content

Added some clarifying comments, fixed watchable key deletion in the

Codecov / codecov/project succeeded May 22, 2024 in 0s

66.80% (target 60.00%)

View this Pull Request on Codecov

66.80% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 42.90429% with 173 lines in your changes are missing coverage. Please review.

Project coverage is 66.80%. Comparing base (5fb6ff5) to head (b10c677).
Report is 11 commits behind head on main.

❗ Current head b10c677 differs from pull request most recent head 7ba5af2

Please upload reports for the commit 7ba5af2 to get more accurate results.

Files Patch % Lines
internal/provider/kubernetes/controller.go 25.45% 38 Missing and 3 partials ⚠️
internal/gatewayapi/extensionserverpolicy.go 71.21% 28 Missing and 10 partials ⚠️
internal/gatewayapi/runner/runner.go 18.18% 25 Missing and 2 partials ⚠️
internal/provider/kubernetes/status.go 14.81% 22 Missing and 1 partial ⚠️
internal/extension/registry/xds_hook.go 0.00% 20 Missing ⚠️
internal/utils/field/field.go 0.00% 11 Missing ⚠️
internal/provider/kubernetes/status_updater.go 20.00% 7 Missing and 1 partial ⚠️
internal/xds/translator/extension.go 50.00% 2 Missing and 1 partial ⚠️
internal/gatewayapi/resource.go 0.00% 1 Missing ⚠️
internal/message/types.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3371      +/-   ##
==========================================
- Coverage   67.35%   66.80%   -0.55%     
==========================================
  Files         166      165       -1     
  Lines       19357    24092    +4735     
==========================================
+ Hits        13037    16095    +3058     
- Misses       5379     7059    +1680     
+ Partials      941      938       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov