stats: sanitize metric names #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wybczu
force-pushed
the
luk/sanitize-stats-key
branch
from
6f15176 to
c5723b4
Compare
If the configuration contains a key value with a `:` or `|`, e.g.
```
- key: path
value: "/foo:*"
rate_limit:
unit: minute
requests_per_unit: 20
```
the reported statsd metrics are malformed.
Signed-off-by: Lukasz Szczesny <luk@wybcz.pl>
wybczu
force-pushed
the
luk/sanitize-stats-key
branch
from
c5723b4 to
3c86472
Compare
ysawa0
reviewed
Jan 12, 2024
Sure thing! I'll update the PR over the weekend. |
|
@ysawa0 I updated the PR. |
ysawa0
approved these changes
Jan 15, 2024
timcovar
pushed a commit
to goatapp/ratelimit
that referenced
this pull request
Jan 16, 2024
* stats: sanitize metric names
If the configuration contains a key value with a `:` or `|`, e.g.
```
- key: path
value: "/foo:*"
rate_limit:
unit: minute
requests_per_unit: 20
```
the reported statsd metrics are malformed.
Signed-off-by: Lukasz Szczesny <luk@wybcz.pl>
* Add tests
Signed-off-by: Lukasz Szczesny <luk@wybcz.pl>
---------
Signed-off-by: Lukasz Szczesny <luk@wybcz.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the configuration contains a key value with a
:or|, e.g.the reported statsd metrics are malformed.