Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example prom-statsd-exporter config #648

Closed
wants to merge 1 commit into from

Conversation

jcdavis
Copy link

@jcdavis jcdavis commented Jul 12, 2024

Few cleanups for folks using this as a baseline (aka myself):

  1. Remove timer_type for counter metrics, this field is a no-op as-is and is just confusing.
  2. Where it is needed (ratelimit_service_rate_limit_shadow_mode), switch to observer_type, since timer_type has been deprecated since at least 2020: prometheus/statsd_exporter@4a64979
  3. Add a single-key shadow mode match (even if this is not necessary/used by the example ratelimit setup)

Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Aug 11, 2024
@ysawa0
Copy link
Member

ysawa0 commented Aug 15, 2024

Looks great. @jcdavis Should we also update the image ver here? https://github.com/envoyproxy/ratelimit/blob/main/docker-compose-example.yml#L13

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@ysawa0
Copy link
Member

ysawa0 commented Aug 15, 2024

Please fix DCO

@github-actions github-actions bot removed the stale label Aug 15, 2024
Signed-off-by: Jackson Davis <jdavis@metronome.com>
@jcdavis jcdavis force-pushed the update-exporter-config branch from 1e50754 to 2e021c4 Compare August 16, 2024 17:16
@jcdavis jcdavis requested a review from ysawa0 August 16, 2024 17:16
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Sep 15, 2024
Copy link

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants