Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set envconfig DISABLE_STATS true by default #765

Closed
wants to merge 1 commit into from
Closed

set envconfig DISABLE_STATS true by default #765

wants to merge 1 commit into from

Conversation

johnzheng1975
Copy link
Contributor

@johnzheng1975 johnzheng1975 commented Nov 14, 2024 •
edited
Loading

Fix issue: #764

@johnzheng1975
set envconfig DISABLE_STATS true by default
7961f7f 
Signed-off-by: John Zheng <john.zheng@hp.com>
@johnzheng1975
Copy link
Contributor Author

@junr03 , FYI.
I think had better set envconfig DISABLE_STATS true by default, how do you think? Thanks.

@zirain
Copy link
Member

zirain commented Nov 22, 2024

I believe it's better to keep the default as before, it's easy for people to change it in real/prod env.

@johnzheng1975
Copy link
Contributor Author

That's fine. Close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnzheng1975 @zirain