Various improvements around dividend handling #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not supported and causes various issues like: pandas.errors.MergeError: Not allowed to merge between different levels. (2 levels on the left, 1 on the right)
The master DF doesn't contain TZ information either but its presence in dividends DF prevents the two being merged together. Error: ValueError: You are trying to merge on datetime64[ns] and datetime64[ns, America/New_York] columns for key 'Date'. If you wish to proceed you should use pd.concat
"self.datadiv" is a list of dividends for each tick. Adding the whole list of dividends on each processing step is erroneous and also causes various other issues. Error in backtrader/analyzers/drawdown.py", line 93, in notify_fund: ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
Instead of retrying with other exchanges (where the list seems arbitrary).
Previously, only the first transaction was protected by a stop-loss or trailing stop-loss. It also didn't allow for parallel (trailing) stop orders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are various issues when fastquant is used with current Yahoo Finance source (try with S&P500:
^GSPC). I aimed to fix them with these commits.