Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#24] 리뷰 생성 API 개발 #26

Merged
merged 11 commits into from
Mar 28, 2024
Merged

[#24] 리뷰 생성 API 개발 #26

merged 11 commits into from
Mar 28, 2024

Conversation

jay-so
Copy link
Member

@jay-so jay-so commented Mar 28, 2024

👨‍💻 작업 사항

📑 PR 개요

  • 사용자가 등록한 장소에 대해서 리뷰 생성 API를 개발한다.
  • 사용자가 사진을 여러장 저장할 수 있도록 Review Image 엔티티를 분리하여 개발한다.

✅ 작업 목록

  • 사용자가 등록한 장소에 대해서 리뷰 생성 API 개발
  • Review Image 엔티티 분리 개발

@jay-so jay-so added the 신규 기능 [feat] 새로운 기능을 추가한다. label Mar 28, 2024
@jay-so jay-so self-assigned this Mar 28, 2024
@jay-so jay-so linked an issue Mar 28, 2024 that may be closed by this pull request
리뷰 생성 API 개발 #24
Closed
2 tasks
@jay-so jay-so force-pushed the feature/#24 branch 8 times, most recently from f8a7f86 to 94021c4 Compare March 28, 2024 11:31
@jay-so jay-so force-pushed the feature/#24 branch 3 times, most recently from 16bfd99 to 9539d4e Compare March 28, 2024 13:07
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 28, 2024 •
edited
Loading

Quality Gate Failed Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ D)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 28, 2024
View reviewed changes
src/main/java/com/eodya/api/common/service/S3Service.java
try {
File fileObj = convertMultiPartFileToFile(file);
s3Client.putObject(new PutObjectRequest(bucketName, fileName, fileObj));
fileObj.delete();

Check failure

Code scanning / SonarCloud

I/O function calls should not be vulnerable to path injection attacks High

Change this code to not construct the path from user-controlled data. See more on SonarCloud
src/main/java/com/eodya/api/common/service/S3Service.java Dismissed Show dismissed Hide dismissed
@jay-so jay-so merged commit 30f7adc into develop Mar 28, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jay-so jay-so

Labels
신규 기능 [feat] 새로운 기능을 추가한다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

리뷰 생성 API 개발
1 participant
@jay-so