[#25] 회원 가입, 로그인 API개발 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay-so
reviewed
Mar 28, 2024
|
|
||
| @FeignClient(name = "kakaoApiClient", url = "https://kapi.kakao.com") | ||
| public interface KakaoApiClient { | ||
| @GetMapping(value = "/v2/user/me") |
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
| @AllArgsConstructor(access = AccessLevel.PRIVATE) | ||
| public class KakaoUserResponse { | ||
| private Long id; |
| @Getter | ||
| @Configuration | ||
| public class AuthConfig { | ||
| @Value("${jwt.secret}") |
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
| @AllArgsConstructor(access = AccessLevel.PRIVATE) | ||
| public class UserLoginRequest { | ||
| private String token; |
| import com.eodya.api.common.exception.ExceptionCode; | ||
|
|
||
| public class AuthException extends BusinessException { | ||
| public AuthException(ExceptionCode exceptionCode, Object... rejectedValues) { |
| @Getter | ||
| @RequiredArgsConstructor | ||
| public enum AuthExceptionCode implements ExceptionCode { | ||
| INVALID_KAKAO_TOKEN(HttpStatus.BAD_REQUEST, "AUT-001", "유효한 카카오 토큰이 아닙니다."), |
| import com.eodya.api.common.exception.ExceptionCode; | ||
|
|
||
| public class UserException extends BusinessException { | ||
| public UserException(ExceptionCode exceptionCode, Object... rejectedValues) { |
| @Getter | ||
| @RequiredArgsConstructor | ||
| public enum UserExceptionCode implements ExceptionCode { | ||
| USER_NOT_FOUND(HttpStatus.NOT_FOUND, "USE-001", "해당하는 유저를 찾을 수 없음"), |
| import org.springframework.data.jpa.repository.JpaRepository; | ||
|
|
||
| public interface UserRepository extends JpaRepository<User, Long> { | ||
| Optional<User> findByOAuthId(String oauthId); |
| package com.eodya.api.users.service; | ||
|
|
||
| public interface SocialService { | ||
| String getOAuthId(String token); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👨💻 작업 사항
📑 PR 개요
✅ 작업 목록
🙏 리뷰어에게
Feign client를 도입하여 kakao API와 통신했습니다.
유효하지 않은 kakao token 일 경우, AuException을 터뜨리도록 로직을 구성했습니다.
User엔티티에서 OAuthProvider를 enum타입으로 선언했습니다.
jwt 토큰을 도입하여 loing 로직을 구현했습니다.
현재 Exception이 발생했을 때, 코드만 보여주고 있는데 이부분 확인해주시면 감사하겠습니다.
kakao API부분을 현재 external 패키지에 선언했는데, 폴더링 관련해서는 금요일 이후에 다시 얘기 나눠보면 좋을 것 같아요
기타
Closes 회원 가입, 로그인 API개발 #25
Prefix
P1: 꼭 반영해주세요 (Request changes)P2: 적극적으로 고려해주세요 (Request changes)P3: 웬만하면 반영해 주세요 (Comment)P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)P5: 그냥 사소한 의견입니다 (Approve)