fix #136. Updated eole/bin/model/average_models.py to work with safetensors model format. #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror when training multi-gpu
isanvicente
changed the title
francoishernandez
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Looks good! Can you just remove the unnecessary comments (mainly referring to the previous implementation)?
Thanks!
Note: agreed on the "maybe better implemented using model_saver classes", we need to create some subclass other than TrainingModelSaver for such purposes at some point.
|
Sure! done. I deleted all comments except for those in the Cheers, |
francoishernandez
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix proposal for #136.
Updated eole/bin/model/average_models.py to work with safetensors model format.
The script now takes as input/ouput checkpoint directory paths instead of
.ptmodel files.I've used
model_saverpackage functions (eole/models/model_saver.py) to load checkpoints.I tested it with a few models and results seem as expected, but feel free to check if code is correct.