Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fineweb10B/gpt2 recipe, and supporting changes #32

Merged
merged 8 commits into from
Oct 18, 2024

Conversation

francoishernandez
Copy link
Contributor

@francoishernandez francoishernandez commented Jun 14, 2024

This is blatantly inspired from karpathy/llm.c#481.

Some changes in the process:

  • support adamw optimizer;
  • support cosine style decay (linear warmup + cosine decrease to 0);
  • removed param_init_glorot in favor of a more generic param_init_method;
  • check all recipes config in tests.

TODO:

@francoishernandez francoishernandez marked this pull request as draft June 14, 2024 15:41
@francoishernandez francoishernandez marked this pull request as ready for review October 18, 2024 13:47
@francoishernandez francoishernandez changed the title [WIP] fineweb10B/gpt2 recipe, and supporting changes fineweb10B/gpt2 recipe, and supporting changes Oct 18, 2024
@francoishernandez francoishernandez merged commit 022285d into main Oct 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant