-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(security): prevent arbitrary file write in SQL editor (CVE-2024-10835) #2268
fix(security): prevent arbitrary file write in SQL editor (CVE-2024-10835) #2268
Conversation
…0835) Block dangerous DuckDB operations to prevent arbitrary file write and potential RCE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello, @Aries-ckt @sbabybird @AlphaHinex @xudafeng How can my pr request be merged? Right now it needs to be approved by 2 reviewers to be automatically merged. Also, #2269 is another pr I submitted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, there is still a small problem, please format codes, you can run make fmt
to format it.
Thanks for the heads up. It's done and pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR fixes a critical security vulnerability (CVE-2024-10835) in the SQL editor API that could allow attackers to perform arbitrary file write operations through DuckDB SQL queries. The vulnerability could potentially lead to Remote Code Execution (RCE).
Key changes:
How Has This Been Tested?
The security fix has been tested with:
Test Environment:
Snapshots:
Include snapshots for easier review.
Checklist: