New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add display_message support for errors #111

Merged

roman-romanov-o merged 9 commits into development from feat/add-user-display-messages

Jun 3, 2024

Collaborator

roman-romanov-o commented May 31, 2024 •

edited

Loading

resolves #72

roman-romanov-o added 2 commits

May 31, 2024 15:06


          -change internal exception class to sdk exception class

-add display_message where it's possible


          make linter happy

d68f455

roman-romanov-o requested review from adubovik and vladisavvv

May 31, 2024 12:07

Collaborator Author

roman-romanov-o commented May 31, 2024 •

edited

Loading

Theoretically we could use this approach, that is more like one in vertex and bedrock adapter:
https://github.com/epam/ai-dial-adapter-openai/pull/110/files

But then there is problem with proxing any exception from OpenAI:

async def handle_exceptions(call):
    try:
        return await call
    except OpenAIException as e:
        return Response(status_code=e.code, headers=e.headers, content=e.body)
    ...

Collaborator Author

roman-romanov-o commented May 31, 2024 •

edited by ai-dial-actions

Loading

/deploy-review

Environment URL: https://chat-ai-dial-adapter-openai-pr-111.nightly-test.deltixhub.io
E2E tests status: failed

adubovik reviewed

View reviewed changes

aidial_adapter_openai/app.py Outdated Show resolved Hide resolved

adubovik reviewed

View reviewed changes

aidial_adapter_openai/app.py Outdated Show resolved Hide resolved

adubovik reviewed

View reviewed changes

aidial_adapter_openai/gpt4_vision/chat_completion.py Outdated Show resolved Hide resolved

adubovik reviewed

View reviewed changes

aidial_adapter_openai/utils/auth.py Outdated Show resolved Hide resolved

adubovik reviewed

View reviewed changes

aidial_adapter_openai/utils/tokens.py Outdated Show resolved Hide resolved

adubovik reviewed

View reviewed changes

aidial_adapter_openai/utils/tokens.py Outdated Show resolved Hide resolved

roman-romanov-o added 4 commits

June 3, 2024 11:47


          Fix message content

16893c0


          Merge branch 'development' into feat/add-user-display-messages

abfb6fb


          Fix gpt4 multi-modal

fee9541


          Fix tokens module

e084e43

Collaborator Author

roman-romanov-o commented Jun 3, 2024 •

edited by ai-dial-actions

Loading

/deploy-review

Environment URL: https://chat-ai-dial-adapter-openai-pr-111.nightly-test.deltixhub.io
E2E tests status: success

roman-romanov-o added 2 commits

June 3, 2024 13:47


          Minor fix of message text

e0d2bba


          another minor fix of text

93c42cd

adubovik reviewed

View reviewed changes

aidial_adapter_openai/utils/tokens.py Outdated Show resolved Hide resolved

adubovik reviewed

View reviewed changes

aidial_adapter_openai/utils/tokens.py Outdated Show resolved Hide resolved


          avoid duplication, make message and display_message same

0d26b65

Collaborator Author

roman-romanov-o commented Jun 3, 2024 •

edited by ai-dial-actions

Loading

/deploy-review

Environment URL: https://chat-ai-dial-adapter-openai-pr-111.nightly-test.deltixhub.io
E2E tests status: failed

adubovik approved these changes

View reviewed changes

Collaborator Author

roman-romanov-o commented Jun 3, 2024 •

edited by ai-dial-actions

Loading

/deploy-review

Environment URL: https://chat-ai-dial-adapter-openai-pr-111.nightly-test.deltixhub.io
E2E tests status: failed

3 similar comments

Collaborator Author

roman-romanov-o commented Jun 3, 2024 •

edited by ai-dial-actions

Loading

/deploy-review

Environment URL: https://chat-ai-dial-adapter-openai-pr-111.nightly-test.deltixhub.io
E2E tests status: failed

Collaborator Author

roman-romanov-o commented Jun 3, 2024 •

edited by ai-dial-actions

Loading

/deploy-review

Environment URL: https://chat-ai-dial-adapter-openai-pr-111.nightly-test.deltixhub.io
E2E tests status: failed

Collaborator Author

roman-romanov-o commented Jun 3, 2024 •

edited by ai-dial-actions

Loading

/deploy-review

Environment URL: https://chat-ai-dial-adapter-openai-pr-111.nightly-test.deltixhub.io
E2E tests status: failed

roman-romanov-o merged commit ce4a06b into development

6 checks passed

Collaborator Author

roman-romanov-o commented Jun 3, 2024 •

edited by ai-dial-actions

Loading

/deploy-review

Environment URL: https://chat-ai-dial-adapter-openai-pr-111.nightly-test.deltixhub.io
E2E tests status: failed

Collaborator Author

roman-romanov-o commented Jun 4, 2024 •

edited by ai-dial-actions

Loading

/deploy-review

Environment URL: https://chat-ai-dial-adapter-openai-pr-111.nightly-test.deltixhub.io
E2E tests status: success

adubovik pushed a commit that referenced this pull request


          feat: add display_message support for errors (#111)

7280f56

adubovik deleted the feat/add-user-display-messages branch

June 13, 2024 08:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet