Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed bug in collection of text context parts #90

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

adubovik
Copy link
Collaborator

Analytics didn't correctly collect content from the text content parts like this one:

{
  "messages": [
    {
      "role": "system",
      "content": [
        {
          "type": "text",
          "text": "text!"
        }
      ]
    },
    { "role": "user", "content": "test!" }
  ]
}

because of a typo in the content field name:

if isinstance(content_part, dict):
if content_part.get("type") == "text" and (
text := content_part.get("content")
):
ret.extend(text)

The typo content -> text was fixed.

Also, the empty strings are moved from the content.

@adubovik adubovik self-assigned this Dec 27, 2024
@adubovik adubovik requested a review from Allob as a code owner December 27, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant