Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): disable new conversation on click when HideNewConversation is enabled (Issue #2792) #2796

Merged
merged 13 commits into from
Dec 12, 2024

Conversation

Derikyan
Copy link
Contributor

@Derikyan Derikyan commented Dec 12, 2024

Description:

Need to forbid the creation of a new conversation on DIAL Logo click if HideNewConversation feature is enabled

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@Derikyan Derikyan added the bug Something isn't working label Dec 12, 2024
@Derikyan Derikyan self-assigned this Dec 12, 2024
@Derikyan
Copy link
Contributor Author

Derikyan commented Dec 12, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2796.nightly-test.deltixhub.io
E2E tests status: success

@Derikyan Derikyan enabled auto-merge (squash) December 12, 2024 13:07
@IlyaBondar IlyaBondar self-requested a review December 12, 2024 17:43
@Derikyan Derikyan disabled auto-merge December 12, 2024 17:47
@Derikyan Derikyan enabled auto-merge (squash) December 12, 2024 17:55
@Derikyan Derikyan merged commit ebadd84 into development Dec 12, 2024
8 checks passed
@Derikyan Derikyan deleted the fix/2792-disable-logo-click-hideNewConversation branch December 12, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants