Add zoom in/out limitations #558
Conversation
| @@ -7,6 +7,6 @@ module.exports = { | |||
| 'alpha-value-notation': 'number', | |||
| 'property-no-vendor-prefix': null, | |||
| 'declaration-block-no-redundant-longhand-properties': null, | |||
| 'scss/at-import-partial-extension': 'always', | |||
There was a problem hiding this comment.
Thank you for your interest in improving Miew!
Unfortunately, it appears that the rule you've suggested is no longer supported in stylelint-config-recommended-scss v14.1.0. We currently use stylelint-config-standard-scss v^13.1.0, which relies on an earlier version of the recommended rules. As a result, we're unable to incorporate this specific rule change at this time.
|
|
||
| // avoid zoom getting lost in space | ||
| const tooSmall = this.object.scale.x <= 0.0005 && factor < 1; | ||
| const tooBig = this.object.scale.x >= 20 && factor > 1; |
There was a problem hiding this comment.
Thanks for your contribution and the idea to limit scaling! We appreciate the effort put into this pull request.
Unfortunately, using fixed constant limits for zooming might not be ideal for all scenarios. For instance, zooming out on elements like 2FBU could become problematic, as shown in the image 
). As you can see in the other image 
, the proposed code restricts zooming out a bit too much in this case.
Let's continue the discussion on alternative approaches in issue #557? Perhaps we can explore a more dynamic scaling solution that adapts to different elements.
|
Sorry, we are not merging the PR |
Description
Set limitations to how much the user can scroll in or out, plus fix issue #556.
Type of changes
Checklist
yarn run ci: lint and tests pass locally with my changes.