Extract definitions/theorems of functions, add Sigma and Pi #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilangyu
commented
Apr 29, 2024
Comment on lines
+296
to
+310
| // class SetOfFunctions(val x: Term, val y: Term) extends AppliedFunctional(setOfFunctions, Seq(x, y)) with LisaObject[SetOfFunctions] { | ||
| // override def substituteUnsafe(map: Map[lisa.fol.FOL.SchematicLabel[?], lisa.fol.FOL.LisaObject[?]]): SetOfFunctions = SetOfFunctions(x.substituteUnsafe(map), y.substituteUnsafe(map)) | ||
|
|
||
| // override def toString(): String = x.toStringSeparated() + " |=> " + y.toStringSeparated() | ||
| // override def toStringSeparated(): String = toString() | ||
| // } | ||
| // object SetOfFunctions { | ||
| // def unapply(sof: SetOfFunctions): Option[(Term, Term)] = sof match | ||
| // case AppliedFunctional(label, Seq(x, y)) if label == setOfFunctions => Some((x, y)) | ||
| // case _ => None | ||
| // } | ||
| // extension (x: Term) { | ||
| // // Infix notation for a set of functions: x |=> y | ||
| // def |=>(y: Term): Term = SetOfFunctions(x, y) | ||
| // } |
There was a problem hiding this comment.
There is one regression: in the type package |=> was used as the setOfFunctions, but it was declared as an infix which gave nicer printing. I tried to replicate this here but I failed. The with LisaObject[SetOfFunctions] part was raising an error of Type argument lisa.maths.settheory.functions.Functionals.SetOfFunctions does not conform to upper bound Common.this.LisaObject[lisa.maths.settheory.functions.Functionals.SetOfFunctions]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slimmed down SetTheory a bit, should make it easier to find theorems.
For reviewing: The first commit is moving existing things to the new package, the following commits are newly added things.