Merge pull request #145 from Unshut-Labs/noe/db-sql-crash

Noe/db sql crash

components/XmtpEngine.tsx

@@ -11,6 +11,10 @@ import { useAppStore } from "../data/store/appStore";
 import { useSelect } from "../data/store/storeHelpers";
 import { getTopicsData } from "../utils/api";
 import { loadSavedNotificationMessagesToContext } from "../utils/notifications";
+import {
+  dropXmtpClientsDbConnections,
+  reconnectXmtpClientsDbConnections,
+} from "../utils/xmtpRN/client";
 import { createPendingConversations } from "../utils/xmtpRN/conversations";
 import { sendPendingMessages } from "../utils/xmtpRN/send";
 import { syncXmtpClient } from "../utils/xmtpRN/sync";
@@ -72,10 +76,16 @@ export default function XmtpEngine() {
           appState.current.match(/inactive|background/) &&
           hydrationDone
         ) {
+          await reconnectXmtpClientsDbConnections();
           loadSavedNotificationMessagesToContext();
           if (isInternetReachableRef.current) {
             syncAccounts(accounts);
           }
+        } else if (
+          nextAppState.match(/inactive|background/) &&
+          appState.current === "active"
+        ) {
+          await dropXmtpClientsDbConnections();
         }
         appState.current = nextAppState;
       }
@@ -105,7 +115,10 @@ export default function XmtpEngine() {
   const runningCron = useRef(false);
 
   const xmtpCron = useCallback(async () => {
-    if (!useAppStore.getState().splashScreenHidden) {
+    if (
+      !useAppStore.getState().splashScreenHidden ||
+      AppState.currentState.match(/inactive|background/)
+    ) {
       return;
     }
     runningCron.current = true;

data/db/index.ts

@@ -1,4 +1,4 @@
-import { Platform } from "react-native";
+import { AppState, Platform } from "react-native";
 import RNFS from "react-native-fs";
 import { Repository } from "typeorm/browser";
 
@@ -38,7 +38,13 @@ export const getRepository = async <T extends keyof RepositoriesForAccount>(
   // init. This means methods that try to interact with the database too
   // early will not fail but just take longer to execute!
 
-  while (!repositories[account]?.[entity]) {
+  // We also use the same mechanism to postpone writing to
+  // database if the app is in background
+
+  while (
+    !repositories[account]?.[entity] ||
+    AppState.currentState.match(/inactive|background/)
+  ) {
     console.log(`Database for ${account} not yet initialized`);
     await new Promise((r) => setTimeout(r, 100));
   }

utils/xmtpRN/client.ts

@@ -62,3 +62,27 @@ export const isOnXmtp = async (address: string) =>
 export const xmtpClientByAccount: {
   [account: string]: ConverseXmtpClientType;
 } = {};
+
+// On iOS, it's important to stop writing to SQLite database
+// when the app is going from BACKGROUNDED to SUSPENDED
+// (see https://github.com/xmtp/xmtp-ios/issues/336)
+
+// There are currently 2 SQLite databases:
+// 1st one managed by Converse, created to store v2 XMTP data
+// 2nd one managed by LibXMTP, created to store v3 XMTP data
+
+// Let's just stop writing to both of them as soon as the app is BACKGROUNDED
+
+export const dropXmtpClientsDbConnections = async () => {
+  await Promise.all(
+    Object.values(xmtpClientByAccount).map((c) =>
+      c.dropLocalDatabaseConnection()
+    )
+  );
+};
+
+export const reconnectXmtpClientsDbConnections = async () => {
+  await Promise.all(
+    Object.values(xmtpClientByAccount).map((c) => c.reconnectLocalDatabase())
+  );
+};

utils/xmtpRN/client.web.ts

@@ -37,3 +37,7 @@ export const isOnXmtp = async (address: string) =>
   Client.canMessage(getCleanAddress(address), {
     env,
   });
+
+export const dropXmtpClientsDbConnections = async () => {};
+
+export const reconnectXmtpClientsDbConnections = async () => {};