fix: Sending on return key

[alexrisch]

Add platform check for return key

Summary by CodeRabbit

• Refactor
  • Updated the declaration of ChatInputProps from an interface to a type alias for improved clarity.
  • Simplified the onSubmitEditing prop handling in the TextInput component.
  • Added a conditional check for the "Enter" key in the onKeyPress event handler for better cross-platform compatibility.

[github-actions]

Performance Comparison Report

• Current: 5c3aff0 - 2024-11-21 16:22:02Z
• Baseline: release/2.0.9 (dfab858) - 2024-11-21 16:21:00Z

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries

Name	Type	Duration	Count
Avatar Image 10 runs	render	1.2 ms → 1.2 ms	1 → 1
Avatar Image 50 runs	render	1.1 ms → 1.1 ms (-0.0 ms, -1.8%)	1 → 1
Empty Avatar 10 runs	render	0.9 ms → 1.0 ms (+0.1 ms, +11.1%)	1 → 1
Empty Avatar 50 runs	render	0.8 ms → 0.7 ms (-0.1 ms, -12.5%)	1 → 1
Empty PressableProfileWithText 10 runs	render	0.7 ms → 1.0 ms (+0.3 ms, +42.9%) 🔴	1 → 1
Empty PressableProfileWithText 50 runs	render	0.6 ms → 0.6 ms (-0.1 ms, -9.4%)	1 → 1
PressableProfileWithText Image 10 runs	render	0.4 ms → 0.7 ms (+0.3 ms, +75.0%) 🔴	1 → 1
PressableProfileWithText Image 50 runs	render	0.8 ms → 0.6 ms (-0.2 ms, -23.1%) 🟢	1 → 1
Text Component with color prop - 10 runs	render	0.4 ms → 0.2 ms (-0.2 ms, -50.0%) 🟢	1 → 1
Text Component with default props - 10 runs	render	0.3 ms → 0.1 ms (-0.2 ms, -66.7%) 🟢	1 → 1
Text Component with translation key - 10 runs	render	0.3 ms → 0.1 ms (-0.2 ms, -66.7%) 🟢	1 → 1
Text Component with weight and size - 10 runs	render	0.3 ms → 0.1 ms (-0.2 ms, -66.7%) 🟢	1 → 1

Show details

Name	Type	Duration	Count
Avatar Image 10 runs	render	Baseline Mean: 1.2 ms Stdev: 0.4 ms (35.1%) Runs: 1 1 1 1 1 2 1 1 2 1 Warmup runs: 2 Current Mean: 1.2 ms Stdev: 0.4 ms (35.1%) Runs: 1 1 1 2 1 1 1 1 1 2 Warmup runs: 2	Baseline Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 Render issues: Current Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 Render issues:
Avatar Image 50 runs	render	Baseline Mean: 1.1 ms Stdev: 0.3 ms (29.3%) Runs: 1 1 1 1 2 1 1 2 1 1 1 1 1 1 1 1 1 1 1 1 2 2 1 1 1 1 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 2 1 1 1 1 1 Warmup runs: 2 Current Mean: 1.1 ms Stdev: 0.3 ms (27.5%) Runs: 1 1 1 1 1 2 1 1 1 1 1 1 2 1 1 2 1 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 Warmup runs: 1	Baseline Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 Render issues: Current Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 Render issues:
Empty Avatar 10 runs	render	Baseline Mean: 0.9 ms Stdev: 0.3 ms (35.1%) Runs: 1 1 1 1 1 1 1 0 1 1 Warmup runs: 3 Current Mean: 1.0 ms Stdev: 0.5 ms (47.1%) Runs: 1 1 1 1 1 1 1 2 0 1 Warmup runs: 9	Baseline Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 Render issues: Current Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 Render issues:
Empty Avatar 50 runs	render	Baseline Mean: 0.8 ms Stdev: 0.4 ms (50.5%) Runs: 1 0 1 1 1 0 1 1 1 1 1 0 1 1 1 0 1 1 0 1 1 1 1 1 1 1 1 1 1 0 1 0 1 1 1 0 1 1 1 1 1 1 1 0 1 1 1 0 1 1 Warmup runs: 0 Current Mean: 0.7 ms Stdev: 0.5 ms (66.1%) Runs: 1 1 1 0 1 0 1 0 1 0 0 1 0 1 1 1 1 0 1 1 1 1 1 1 1 1 1 0 1 1 0 0 1 1 1 1 0 0 1 1 1 1 1 0 1 1 0 0 1 1 Warmup runs: 1	Baseline Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 Render issues: Current Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 Render issues:
Empty PressableProfileWithText 10 runs	render	Baseline Mean: 0.7 ms Stdev: 0.5 ms (69.0%) Runs: 1 0 0 1 1 0 1 1 1 1 Warmup runs: 4 Current Mean: 1.0 ms Stdev: 0.0 ms (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 Warmup runs: 2	Baseline Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 Render issues: Current Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 Render issues:
Empty PressableProfileWithText 50 runs	render	Baseline Mean: 0.6 ms Stdev: 0.5 ms (75.8%) Runs: 1 1 0 0 1 1 1 1 0 0 1 1 0 0 0 1 1 0 0 1 1 1 0 1 1 0 1 1 1 1 0 0 1 1 0 1 1 0 1 0 1 1 1 0 0 1 1 1 1 1 Warmup runs: 1 Current Mean: 0.6 ms Stdev: 0.5 ms (86.0%) Runs: 1 0 1 1 1 1 0 1 0 1 0 0 0 0 1 1 1 1 0 1 0 1 0 0 0 0 1 0 1 1 1 1 1 1 0 0 1 1 1 0 0 1 1 0 1 0 1 1 1 0 Warmup runs: 0	Baseline Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 Render issues: Current Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 Render issues:
PressableProfileWithText Image 10 runs	render	Baseline Mean: 0.4 ms Stdev: 0.5 ms (129.1%) Runs: 1 0 1 0 1 1 0 0 0 0 Warmup runs: 1 Current Mean: 0.7 ms Stdev: 0.5 ms (69.0%) Runs: 1 0 1 1 1 1 1 1 0 0 Warmup runs: 1	Baseline Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 Render issues: Current Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 Render issues:
PressableProfileWithText Image 50 runs	render	Baseline Mean: 0.8 ms Stdev: 0.4 ms (53.6%) Runs: 0 1 0 1 1 1 1 1 0 1 1 1 1 1 1 0 1 0 1 1 1 0 1 1 0 1 1 1 1 1 1 1 1 1 1 1 0 1 1 0 1 1 0 0 1 1 1 1 1 1 Warmup runs: 0 Current Mean: 0.6 ms Stdev: 0.5 ms (82.5%) Runs: 0 1 0 1 1 1 0 1 0 1 0 1 1 0 1 1 1 1 0 1 0 0 1 0 1 1 0 0 0 0 1 1 1 1 0 0 1 1 1 0 1 1 0 1 0 1 0 1 1 1 Warmup runs: 1	Baseline Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 Render issues: Current Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 Render issues:
Text Component with color prop - 10 runs	render	Baseline Mean: 0.4 ms Stdev: 0.5 ms (129.1%) Runs: 1 0 0 0 0 1 0 0 1 1 Warmup runs: 0 Current Mean: 0.2 ms Stdev: 0.4 ms (210.8%) Runs: 0 1 0 0 0 1 0 0 0 0 Warmup runs: 0	Baseline Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 Render issues: Current Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 Render issues:
Text Component with default props - 10 runs	render	Baseline Mean: 0.3 ms Stdev: 0.5 ms (161.0%) Runs: 0 0 0 0 0 1 1 1 0 0 Warmup runs: 1 Current Mean: 0.1 ms Stdev: 0.3 ms (316.2%) Runs: 0 0 0 0 0 0 1 0 0 0 Warmup runs: 0	Baseline Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 Render issues: Current Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 Render issues:
Text Component with translation key - 10 runs	render	Baseline Mean: 0.3 ms Stdev: 0.5 ms (161.0%) Runs: 1 1 0 0 0 0 1 0 0 0 Warmup runs: 1 Current Mean: 0.1 ms Stdev: 0.3 ms (316.2%) Runs: 0 0 0 0 0 0 0 0 0 1 Warmup runs: 1	Baseline Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 Render issues: Current Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 Render issues:
Text Component with weight and size - 10 runs	render	Baseline Mean: 0.3 ms Stdev: 0.5 ms (161.0%) Runs: 1 0 0 0 0 0 1 0 1 0 Warmup runs: 1 Current Mean: 0.1 ms Stdev: 0.3 ms (316.2%) Runs: 0 0 0 1 0 0 0 0 0 0 Warmup runs: 0	Baseline Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 Render issues: Current Mean: 1 Stdev: 0 (0.0%) Runs: 1 1 1 1 1 1 1 1 1 1 Render issues:

Render Count Changes

There are no entries

Render Issues

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 331630d

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve refactoring the ChatInputProps interface in the Input.tsx file, converting it from an interface to a type alias. The ChatInput component's logic remains mostly unchanged, but the onSubmitEditing prop is simplified by directly passing the onValidate function. Additionally, a conditional check for the "Enter" key handling is introduced for non-web platforms, while the overall structure and event handling of the component are preserved.

Changes

File	Change Summary
components/Chat/Input/Input.tsx	Changed ChatInputProps from an interface to a type alias; simplified onSubmitEditing prop; added conditional check in onKeyPress for non-web platforms.

Possibly related PRs

• fix: URL Crash  #1084: The changes in the ChatInputProps interface and the handling of props in the ChatInput component may relate to the overall structure and prop management in the chat components, which could be impacted by the modifications in the Chat.tsx and ChatMessage components regarding how messages and frames are processed.

Suggested labels

2.0.7

Suggested reviewers

• thierryskoda

Poem

In the chat where bunnies play,
Input props have found their way.
A type alias now takes the stage,
Simplified, it turns the page.
With every keypress, joy we find,
Hopping forward, leaving doubts behind! 🐇✨

Warning

Rate limit exceeded

@alexrisch has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 8 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 35a93d8 and d5114af.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.