Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ml/nostack 10 22 feat add adr for architectural plans #1282

Merged

Conversation

technoplato
Copy link
Collaborator

@technoplato technoplato commented Dec 3, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced a new context for managing message display states in chat.
    • Added new components for handling message reactions and displaying group updates.
    • Implemented a streamlined chat interface with enhanced user interactions and animations.
  • Bug Fixes

    • Simplified navigation handling across various components.
    • Improved error handling during media uploads and message interactions.
  • Refactor

    • Significant restructuring of the chat components for better modularity and maintainability.
    • Removed deprecated components and streamlined the props structure across several chat-related files.
  • Documentation

    • Updated README and documentation to reflect changes in the chat interface and new components.

@technoplato technoplato requested review from a team as code owners December 3, 2024 17:36
Copy link
Contributor

coderabbitai bot commented Dec 3, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request encompasses a series of significant changes to the codebase, including the removal of the ESLint configuration file, modifications to several GitHub workflow files for building and testing the application, and the deletion of multiple components and utility files related to chat functionality. Additionally, new components and context management for message reactions have been introduced, alongside updates to the configuration files for both Android and Expo. These changes aim to streamline the application structure and enhance the management of chat messages and user interactions.

Changes

File Path Change Summary
.eslintrc.json Configuration file removed.
.github/workflows/build-app-release.yml Modified build steps for Android and iOS, including script path updates and profile changes.
.github/workflows/build-internal.yml Streamlined build process for Android and iOS with updated environment handling and profile naming conventions.
.github/workflows/testflight.yml Workflow removed.
.prettierrc Minor formatting change to the trailingComma property.
App.tsx Updated imports and state management; replaced XmtpEngine with Snackbars.
App.web.tsx Main application component removed.
README.md Updated instructions for building and testing, including new testing sections and simplified Android setup.
__mocks__/@sentry/react-native.ts Mock implementation for Sentry library added.
adr/adr.001.folder and file structure.md Document updates for folder structure proposal and migration plan.
android/app/build.gradle Updated React Native configuration and dependency versions.
android/app/src/main/AndroidManifest.xml Removed comments and modified service declarations.
android/app/src/main/google-services.json New JSON configuration file added for Android app.
android/app/src/main/java/com/converse/MainActivity.kt Package declaration updated; modifications to activity delegate creation.
android/app/src/main/java/com/converse/MainApplication.kt Package declaration updated.
android/app/src/main/java/com/converse/dev/AsyncStorage.kt File removed.
android/app/src/main/java/com/converse/dev/BackendApi.kt File removed.
android/app/src/main/java/com/converse/dev/Datatypes.kt File removed.
android/app/src/main/java/com/converse/dev/Keychain.kt File removed.
android/app/src/main/java/com/converse/dev/MessageNotification.kt File removed.
android/app/src/main/java/com/converse/dev/Mmkv.kt File removed.
android/app/src/main/java/com/converse/dev/NotificationParser.kt File removed.
android/app/src/main/java/com/converse/dev/NotificationUtils.kt File removed.
android/app/src/main/java/com/converse/dev/Profile.kt File removed.
android/app/src/main/java/com/converse/dev/PushNotificationsService.kt File removed.
android/app/src/main/java/com/converse/dev/Sentry.kt File removed.
android/app/src/main/java/com/converse/dev/Spam.kt File removed.
android/app/src/main/java/com/converse/dev/Sqlite.kt File removed.
android/app/src/main/java/com/converse/dev/Utils.kt File removed.
android/app/src/main/java/com/converse/dev/xmtp/Client.kt File removed.
android/app/src/main/java/com/converse/dev/xmtp/Conversations.kt File removed.
android/app/src/main/java/com/converse/dev/xmtp/Messages.kt File removed.
android/app/src/main/res/values/strings.xml String resource updated for expo_runtime_version.
android/app/src/preview/AndroidManifest.xml New manifest file created for preview version.
android/app/src/preview/google-services.json New configuration file added for preview version.
android/app/src/preview/res/values/strings.xml New string resource file added for preview version.
android/app/src/prod/AndroidManifest.xml New manifest file created for production version.
android/app/src/prod/google-services.json New configuration file added for production version.
android/app/src/prod/res/values/strings.xml New string resource file added for production version.
android/gradle.properties New properties added for build configuration.
android/gradle/wrapper/gradle-wrapper.properties Gradle version updated from 8.7 to 8.8.
android/react-settings-plugin/build.gradle.kts New Gradle build script for the react-settings-plugin added.
android/react-settings-plugin/src/main/kotlin/expo/plugins/ReactSettingsPlugin.kt New Kotlin file for ReactSettingsPlugin added.
android/settings.gradle Modifications to plugin management and dependency resolution management.
app.json Version and build numbers updated for iOS and Android.
babel.config.js Module resolution paths refined and specific mappings removed.
components/AccountSettingsButton.tsx Refactored to use useRouter for navigation; removed navigation prop.
components/AndroidBackAction.tsx Removed unused import; updated margin styling.
components/AnimatedBlurView.tsx Simplified parameter handling in component.
components/Button/Button.ios.tsx iOS button component removed.
components/Button/Button.tsx Deprecated old button implementation; redirected to new design system button.
components/Chat/ActionButton.tsx Prop structure simplified; new async functions for attachment handling.
components/Chat/Attachment/AddAttachmentButton.tsx Refactored to remove props; integrated new async functions for media selection.
components/Chat/Attachment/AttachmentMessagePreview.tsx Introduced new hooks and components for remote attachment handling.
components/Chat/Attachment/SendAttachmentPreview.tsx Prop structure simplified; updated layout and button functionality.
components/Chat/Chat.tsx Complete removal of the Chat component.
components/Chat/ChatDumb.tsx New component for chat interface introduced.
components/Chat/ChatGroupUpdatedMessage.tsx Refactored to use subcomponents for group updates.
components/Chat/ChatNullState.tsx Simplified props and component structure.
components/Chat/ChatPlaceholder/ChatPlaceholder.tsx Complete comment-out of existing implementation.
components/Chat/ChatPlaceholder/GroupChatPlaceholder.tsx Group chat placeholder component removed.
components/Chat/ConsentPopup/ConsentPopup.tsx Updated consent handling logic and props structure.
components/Chat/ConsentPopup/GroupConsentPopup.tsx Refactored to simplify group consent logic and props.
components/Chat/Frame/FrameBottom.tsx Prop updated to simplify message ownership handling.
components/Chat/Frame/FramePreview.tsx Extensive commented-out code indicating a refactor or cleanup effort.
components/Chat/Frame/FramesPreviews.tsx Complete commenting out of functionality, indicating a potential refactor.
components/Chat/Frame/urlProtocols.ts New file added to manage authorized URL protocols.
components/Chat/Input/Input.tsx Chat input component removed.
components/Chat/Input/InputReplyBubble.tsx Input reply bubble component removed.
components/Chat/Input/InputReplyPreview.tsx Input reply preview component removed.
components/Chat/Input/SendButton.tsx Send button component removed.
components/Chat/Message/Message.tsx Significant removal of message component logic and dependencies.
components/Chat/Message/Message.utils.tsx New utility functions for message handling added.
components/Chat/Message/MessageActions.tsx Chat message actions component removed.
components/Chat/Message/MessageBubble.tsx New container components for message bubbles added.
components/Chat/Message/MessageContext.tsx New context for managing message display states introduced.
components/Chat/Message/MessageContextMenu.tsx Significant internal logic modifications in the message context menu.
components/Chat/Message/MessageReactions.tsx Chat message reactions component removed.
components/Chat/Message/MessageReactions/MessageReactions.tsx New component for displaying message reactions added.
components/Chat/Message/MessageReactions/MessageReactions.types.ts New type definitions for message reactions added.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant ChatService
    User->>App: Send Message
    App->>ChatService: Process Message
    ChatService-->>App: Acknowledge
    App-->>User: Display Message
Loading

Possibly related PRs

  • fix: Render Frame on initial send #1067: Addresses rendering issues related to frames in chat, which is directly relevant to the main PR's changes involving the removal of the .eslintrc.json file that contained linting rules for React components, potentially affecting how frames are rendered.
  • fix: Frames Renders on initial Send #1113: Focuses on improving the management of frames within the application, specifically enhancing the rendering logic for frames during the initial send operation, which aligns with the main PR's context of modifying React component configurations.
  • refactor and fix modal #1094: Deals with modal functionality and includes changes to the Chat component that may indirectly relate to how frames and messages are displayed, relevant to the main PR's focus on React component configurations.
  • fix: EAS Build Fixes #1099: Includes updates to build configurations that could affect how the application compiles and runs, indirectly related to the main PR's changes in configuration files.
  • fix: Fixed Buttons for Certain cases #1127: Updates button functionalities and navigation, which may relate to user interactions with frames in the chat interface, connecting it to the main PR's focus on React component configurations.

Poem

🐇 In the code, a dance we see,
Components change, so gracefully.
With messages sent and frames anew,
A chat transformed, fresh like dew.
In every line, a story spun,
The rabbit hops, the code is fun! 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@technoplato technoplato changed the base branch from main to release/3.0.0 December 3, 2024 17:36
@alexrisch alexrisch merged commit 067a836 into release/3.0.0 Dec 3, 2024
1 check was pending
@alexrisch alexrisch deleted the ml/nostack-10-22-feat_add_adr_for_architectural_plans branch December 3, 2024 17:38
technoplato added a commit that referenced this pull request Dec 17, 2024
* feat: Add ADR for architectural plans

* Update adr.002.architecture-poc-for-business-logic-and-dependencies-group-joining.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants