Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EAS Node Versions #1435

Merged
merged 4 commits into from
Dec 23, 2024
+8 −10
Merged

fix: EAS Node Versions #1435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9092fd4
fix: EAS Node Versions
alexrisch Dec 22, 2024
bb347b6
[create-pull-request] automated change (#1437)
github-actions[bot] Dec 23, 2024
0813e04
[create-pull-request] automated change (#1438)
github-actions[bot] Dec 23, 2024
f18371c
Remove openssl to handle app store submit with xcode 16
alexrisch Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
"expo": {
"version": "2.1.0",
"ios": {
"buildNumber": "50"
"buildNumber": "52"
},
"android": {
"versionCode": 249
"versionCode": 251
Comment on lines +5 to +8
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version increments appear to be off by one from what's described in the PR summary. The PR indicates iOS buildNumber should be "51" and Android versionCode should be "250", but they're set to "52" and "251" respectively in the code changes.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

}
}
}
4 changes: 2 additions & 2 deletions eas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"env": {
"EXPO_ENV": "dev"
},
"node": "20.15.1",
"node": "20.18.0",
"ios": {
"cocoapods": "1.16.2",
"image": "macos-sonoma-14.6-xcode-16.1"
Expand All @@ -27,7 +27,7 @@
"buildType": "app-bundle",
"resourceClass": "large"
},
"node": "20.15.1",
"node": "20.18.0",
"ios": {
"resourceClass": "large",
"cocoapods": "1.16.2",
Expand Down
1 change: 0 additions & 1 deletion ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ target 'Converse' do
pod 'MMKV', $mmkvVersion, :linkage => :dynamic
pod 'MMKVCore', $mmkvVersion, :linkage => :dynamic
pod 'XMTP', $xmtpVersion, :modular_headers => true
pod "OpenSSL-Universal", "1.1.2200"

use_react_native!(
:path => config[:reactNativePath],
Expand Down
9 changes: 4 additions & 5 deletions ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ PODS:
- MMKVAppExtension (1.3.3):
- MMKVCore (~> 1.3.3)
- MMKVCore (1.3.3)
- OpenSSL-Universal (1.1.2200)
- OpenSSL-Universal (3.3.2000)
- PromisesObjC (2.4.0)
- RCT-Folly (2024.01.01.00):
- boost
Expand Down Expand Up @@ -2311,7 +2311,6 @@ DEPENDENCIES:
- MMKV (= 1.3.3)
- MMKVAppExtension (= 1.3.3)
- MMKVCore (= 1.3.3)
- OpenSSL-Universal (= 1.1.2200)
- RCT-Folly (from `../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec`)
- RCT-Folly/Fabric (from `../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec`)
- RCTDeprecation (from `../node_modules/react-native/ReactApple/Libraries/RCTFoundation/RCTDeprecation`)
Expand Down Expand Up @@ -2795,7 +2794,7 @@ SPEC CHECKSUMS:
MMKV: f902fb6719da13c2ab0965233d8963a59416f911
MMKVAppExtension: fcf23c6b250cc87db63507bc57be8e6ed378168d
MMKVCore: d26e4d3edd5cb8588c2569222cbd8be4231374e9
OpenSSL-Universal: 6e1ae0555546e604dbc632a2b9a24a9c46c41ef6
OpenSSL-Universal: b60a3702c9fea8b3145549d421fdb018e53ab7b4
PromisesObjC: f5707f49cb48b9636751c5b2e7d227e43fba9f47
RCT-Folly: 34124ae2e667a0e5f0ea378db071d27548124321
RCTDeprecation: 726d24248aeab6d7180dac71a936bbca6a994ed1
Expand Down Expand Up @@ -2899,8 +2898,8 @@ SPEC CHECKSUMS:
UMAppLoader: f17a5ee8e85b536ace0fc254b447a37ed198d57e
XMTP: b5311154b2a3cda7c07ce78ae9fa6d111bac979d
XMTPReactNative: 2a8cb6762dd530574888fe1a0ea209baf33b3155
Yoga: a9ef4f5c2cd79ad812110525ef61048be6a582a4
Yoga: b05994d1933f507b0a28ceaa4fdb968dc18da178

PODFILE CHECKSUM: d0979efccd68d98c9fc5de08ece9c978b5338ee0
PODFILE CHECKSUM: cd340e2564f5ae6c64a51a8be3490a9179a697a7

COCOAPODS: 1.16.2
Loading