-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove V2 JS SDK and other dependencies #1531
Conversation
WalkthroughThis pull request involves significant updates to the project's XMTP (Extensible Message Transport Protocol) integration. The changes include modifying Babel configuration, updating type definitions, removing and adding dependencies, and adjusting import statements. The modifications appear to be part of a broader effort to streamline and update the XMTP-related packages and configurations, focusing on type safety and package management. Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (6)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
utils/xmtpRN/sync.ts (1)
54-56
: Consider removing unnecessary type assertion.The type assertion to
Promise<ConverseXmtpClientType>
might be unnecessary since the types should already align based on the type definition on line 20.- return instantiatingClientForAccount[ - lowerCaseAccount - ] as Promise<ConverseXmtpClientType>; + return instantiatingClientForAccount[lowerCaseAccount];
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
📒 Files selected for processing (7)
babel.config.js
(0 hunks)config.ts
(1 hunks)package.json
(1 hunks)patches/@xmtp+user-preferences-bindings-wasm+0.3.6.patch
(0 hunks)utils/test/xmtp.ts
(0 hunks)utils/xmtpRN/content-types/coinbasePayment.ts
(1 hunks)utils/xmtpRN/sync.ts
(2 hunks)
💤 Files with no reviewable changes (3)
- babel.config.js
- utils/test/xmtp.ts
- patches/@xmtp+user-preferences-bindings-wasm+0.3.6.patch
✅ Files skipped from review due to trivial changes (1)
- utils/xmtpRN/content-types/coinbasePayment.ts
🔇 Additional comments (3)
package.json (1)
80-81
: LGTM! Dependencies updated to remove V2 JS SDK.The changes align with the PR objective by removing the V2 JS SDK (@xmtp/xmtp-js) and related packages while adding the necessary V2 replacements.
config.ts (1)
7-7
: LGTM! Type safety improvement for XMTP environment configuration.The addition of the
XmtpEnv
type enhances type safety by constraining environment values to valid options.utils/xmtpRN/sync.ts (1)
20-20
: LGTM! Type simplification aligns with V2 SDK removal.The removal of the
Client
type from union types streamlines the type system and aligns with the V2 SDK removal.Also applies to: 25-25
Performance Comparison ReportSignificant Changes To DurationThere are no entries Meaningless Changes To DurationShow entries
Show details
Render Count ChangesThere are no entries Render IssuesThere are no entries Added ScenariosThere are no entries Removed ScenariosThere are no entries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - did you double check things still work?
Summary
@xmtp/xmtp-js
,@xmtp/content-type-reaction
,@xmtp/content-type-read-receipt
,@xmtp/content-type-remote-attachment
,@xmtp/content-type-reply
, and@xmtp/content-type-transaction-reference
dependencies@xmtp/content-type-transaction-reference
dependency@xmtp/content-type-primitives
dependency@xmtp/user-preferences-bindings-wasm
Summary by CodeRabbit
Release Notes
Dependencies
Configuration
Type Changes
Removed Utilities
These changes represent updates to the project's XMTP integration and dependency management.