Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default group avatars #195

Merged
merged 10 commits into from
Jul 3, 2024
Merged

Conversation

saulmc
Copy link
Member

@saulmc saulmc commented Jun 29, 2024

Implements facepile default group avatars per the following logic:

  • display up to 4 avatars in bubbles
  • arrange bubbles roughly clockwise in descending size
  • for 5 or more avatars, display 5th bubble containing "+n"
  • exclude the sender's avatar from the facepile, except during initial group creation (I could be wrong about this design direction)
  • fall back to the same first letter/0x placeholders as default individual profile avatars
  • if there's at least one group member with an image avatar, display that member's avatar in the first/largest bubble position

Note: in dev, some names/first-letters aren't loading as expected. Not sure what this is, but I'm seeing it in the main feature branch as well

@saulmc saulmc changed the base branch from main to feat/xmtp-groups-dash June 29, 2024 03:38
@saulmc saulmc force-pushed the saulmc/group-avatar-spike branch from b45c627 to 186e551 Compare July 2, 2024 04:05
@saulmc saulmc changed the title Spike on default group avatars Default group avatars Jul 2, 2024
@saulmc saulmc marked this pull request as ready for review July 2, 2024 04:22
@saulmc saulmc linked an issue Jul 2, 2024 that may be closed by this pull request
@saulmc saulmc force-pushed the saulmc/group-avatar-spike branch 2 times, most recently from 49a77a2 to eeab2dc Compare July 2, 2024 23:26
@alexrisch alexrisch force-pushed the saulmc/group-avatar-spike branch from 81f5968 to 85cef81 Compare July 3, 2024 19:20
@alexrisch alexrisch merged commit 23bd90c into feat/xmtp-groups-dash Jul 3, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated group profile images
2 participants