Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Conversation Anatomy (Black is the new Orange) #98

Merged
merged 30 commits into from
Jun 22, 2024

Conversation

saulmc
Copy link
Member

@saulmc saulmc commented Jun 19, 2024

Initial reskin and anatomy changes per #71 and #74

@saulmc saulmc marked this pull request as draft June 19, 2024 00:00
@saulmc saulmc changed the title feat: remove orange from Preview feat: restyle Preview Jun 19, 2024
@saulmc saulmc changed the title feat: restyle Preview feat: restyle Jun 19, 2024
@saulmc saulmc changed the title feat: restyle feat: black is the new orange Jun 19, 2024
@saulmc saulmc changed the title feat: black is the new orange feat: black is the new orange (convo anatomy) Jun 19, 2024
This was linked to issues Jun 19, 2024
@saulmc saulmc changed the title feat: black is the new orange (convo anatomy) feat: Conversation Anatomy (Black is the new Orange) Jun 19, 2024
@saulmc saulmc marked this pull request as ready for review June 21, 2024 09:59
@saulmc saulmc requested a review from alexrisch June 21, 2024 09:59
@alexrisch
Copy link
Collaborator

Simulator Screenshot - iPhone 15 - 2024-06-21 at 11 18 15

I think the left header text needs to be set correctly
light mode is a little light, dark mode is too dark

@saulmc
Copy link
Member Author

saulmc commented Jun 21, 2024

Fixed dark mode here: 76850a3

Lighter text in light mode is as designed, actually:
CleanShot 2024-06-21 at 10 21 01@2x

Concerned you don't have any avatars showing -- how did you get in that state? Or are you just using a solid black pfp (lol)

@alexrisch
Copy link
Collaborator

TLDR: Not an issue, don't worry

I didn't start the metro server, its a fun "feature" of react native, no images load is the server isn't running anymore

@alexrisch alexrisch merged commit ebdb1b7 into feat/xmtp-groups-dash Jun 22, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated conversation anatomy Updated conversation tile anatomy
3 participants