Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purejaxrl example #79

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Conversation

luchris429
Copy link
Contributor

@luchris429 luchris429 commented Jul 3, 2024

Example files for integrating cleanrl / purejaxrl-style PPO implementation.

Should be identical to the purejaxrl implementation.

@epignatelli epignatelli self-requested a review July 4, 2024 15:30
Copy link
Owner

@epignatelli epignatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luchris429 for pushing this!

Could you update the version to the latest available (0.6.15 now, or whatever is the latest at the time you'll read this)?

Other than that LGTM!

@epignatelli epignatelli self-requested a review July 15, 2024 09:33
Copy link
Owner

@epignatelli epignatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank yo uvery much, @luchris429 for pushing this!

The CI / Compliance test fails due insufficient permissions -- I'll fix it in a new branch.

@epignatelli epignatelli merged commit 8c8d7c6 into epignatelli:main Jul 16, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants