Issue 23: Switch sampling order to truncate and then censor #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #23 and as the title switches the order of the sampling process which I think better reflects our assumption about the process (that observation is conditional on the continuous event and not the lower bound of the observation window.
This could be the wrong assumption or in a more complex setting it could be that observation is based on the end of the secondary event window.
I think if we merge this we may want a issue to track this in case we need to provide options (that I think will confuse the majority of users).
Checklist