Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webmock 3.20.0 → 3.23.0 (minor) #238

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Mar 5, 2024

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ webmock (3.20.0 → 3.23.0) · Repo · Changelog

Release Notes

3.22.0 (from changelog)

  • Addressed an issue in the HTTPClient adapter where memoized stubbed responses and memoized request_signatures were incorrectly persisted between subsequent requests (#1019). The implementation of a more robust thread-safety solution by Tom Beauvais in PR #300 not only resolved the memoization problem but also enhanced the overall thread safety of the adapter. This update ensures that stubbed responses and request signatures are correctly isolated to individual requests, improving both consistency and thread safety.

3.21.2 (from changelog)

  • Corrected type checking in WebMock::Response#assert_valid_body! to accurately recognize Hash objects. Additionally, improved the clarity of the error message for unsupported body types, guiding users towards proper usage.

    Thanks to Jake Robb for reporting.

3.21.1 (from changelog)

  • The stubbed Net::HTTPResponse#uri now returns request.uri, aligning it with the behavior of an actual Net::HTTPResponse.

    Thanks to Abe Voelker for reporting and to Victor Maslov and Gio Lodi for the suggested solution.

3.21.0 (from changelog)

  • Don't use deprecated Rack::VERSION for Rack >= 3

    Thanks to Étienne Barrié

  • Updated HTTPClient adapter, to build request signature using the URI after filters have been applied.

    Thanks to Matt Brown

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 20 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot requested a review from epistrephein as a code owner March 5, 2024 21:46
@depfu depfu bot added the dependencies Libraries depended upon label Mar 5, 2024
@epistrephein epistrephein merged commit 056b630 into main Mar 9, 2024
1 check passed
@epistrephein epistrephein deleted the depfu/update/webmock-3.23.0 branch March 9, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Libraries depended upon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant