Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation about constant data removal process. #191

Merged
merged 7 commits into from
Oct 25, 2024

Conversation

Karim-Mane
Copy link
Member

This PR is aimed at addressing issue #171

@Karim-Mane Karim-Mane added the documentation Improvements or additions to documentation label Oct 23, 2024
@Karim-Mane Karim-Mane self-assigned this Oct 23, 2024
vignettes/cleanepi.Rmd Outdated Show resolved Hide resolved
Co-authored-by: Hugo Gruson <10783929+Bisaloo@users.noreply.github.com>
Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Just wanted to read the report and noticed the issue reported in #192 , but this possibly aims to be solved in a separate PR.

@Karim-Mane Karim-Mane linked an issue Oct 24, 2024 that may be closed by this pull request
Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the examples to show how different cutoff values affect an outcome! I suggested three minor edit suggestions for the readability of the sentence by trying to follow semantic line break suggestions like isolating two sections of one sentence. https://sembr.org/

R/remove_constants.R Outdated Show resolved Hide resolved
R/remove_constants.R Outdated Show resolved Hide resolved
R/remove_constants.R Outdated Show resolved Hide resolved
Karim-Mane and others added 3 commits October 25, 2024 10:15
Co-authored-by: Andree Valle Campos <avallecam@gmail.com>
Co-authored-by: Andree Valle Campos <avallecam@gmail.com>
Co-authored-by: Andree Valle Campos <avallecam@gmail.com>
@Karim-Mane
Copy link
Member Author

Thanks for adding this. Just wanted to read the report and noticed the issue reported in #192 , but this possibly aims to be solved in a separate PR.

@avallecam - Thank you for spotting this out. I am fixing this in a separate PR.

@Karim-Mane Karim-Mane closed this Oct 25, 2024
@Karim-Mane Karim-Mane reopened this Oct 25, 2024
Co-authored-by: Andree Valle Campos <avallecam@gmail.com>
@Karim-Mane Karim-Mane merged commit 4a200cc into main Oct 25, 2024
8 checks passed
@Karim-Mane Karim-Mane deleted the fix-issue-171 branch October 25, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
3 participants