Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update touchstone workflow #201

Closed
wants to merge 3 commits into from
Closed

Update touchstone workflow #201

wants to merge 3 commits into from

Conversation

pratikunterwegs
Copy link
Collaborator

@pratikunterwegs pratikunterwegs commented Mar 19, 2024 •
edited
Loading

This PR fixes #184 by updating the touchstone workflow to trigger checks on changes to model code.

@pratikunterwegs pratikunterwegs mentioned this pull request Mar 19, 2024
Closed
@pratikunterwegs pratikunterwegs self-assigned this Mar 19, 2024
@pratikunterwegs pratikunterwegs added the CI Related to continuous integration label Mar 19, 2024
@pratikunterwegs pratikunterwegs linked an issue Mar 19, 2024 that may be closed by this pull request
Add a continuous benchmarking workflow #184
Closed
@github-actions GitHub Actions
Copy link

This is how benchmark results would change (along with a 95% confidence interval in relative change) if ef8901f is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions GitHub Actions
Copy link

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8b6be02 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions GitHub Actions
Copy link

This is how benchmark results would change (along with a 95% confidence interval in relative change) if bb453d8 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation.

@sbfnk
Copy link

sbfnk commented Mar 21, 2024

I think you've discovered lorenzwalthert/touchstone#125 (as I assume you noticed yourself given the other PR).

@pratikunterwegs
Copy link
Collaborator Author

Thanks - indeed, I got stuck in the assumption that I must be doing something wrong but didn't think to check the branch name.

@pratikunterwegs
Copy link
Collaborator Author

Closing this PR as superseded by #206.

@pratikunterwegs pratikunterwegs mentioned this pull request Mar 21, 2024
Merged
@pratikunterwegs pratikunterwegs deleted the dev/touchstone branch March 21, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pratikunterwegs pratikunterwegs

Labels
CI Related to continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a continuous benchmarking workflow
2 participants
@pratikunterwegs @sbfnk