Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epidemics v0.3.0 #217

Merged
merged 16 commits into from
Apr 23, 2024
Merged

epidemics v0.3.0 #217

merged 16 commits into from
Apr 23, 2024

Conversation

pratikunterwegs
Copy link
Collaborator

This PR is working towards a v0.3.0 release by checking off items in #216.

@pratikunterwegs
Copy link
Collaborator Author

pratikunterwegs commented Apr 23, 2024

Some issues thrown up that are worth keeping in mind:

  1. R CMD check requires RcppEigen to be in Imports, but devtools::check(remote = TRUE, manual = TRUE) throws a note that it should "probably only be in LinkingTo", but this addition is IIRC autogenerated by {usethis};
  2. LaTeX issues throw up a warning;
  3. ‘epidemics-manual.tex’ is generated at some point which throws a note;
  4. https://opensource.org/license/mit/ connection times out on some networks, throwing a note;
  5. HTML version of the manual on MacOS throws issues which generate a note.

Copy link

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 376cc99 is merged into main:

  • ✔️default_ode: 10.8ms -> 10.7ms [-2.28%, +0.26%]
  • ✔️default_ode_interventions: 73.8ms -> 73.6ms [-1.27%, +0.88%]
  • ✔️default_ode_param_vec: 825ms -> 825ms [-0.68%, +0.74%]
  • ✔️default_ode_paramvec_intervs: 6.27s -> 6.26s [-0.72%, +0.44%]
  • ✔️ebola: 623ms -> 625ms [-0.63%, +1.1%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@pratikunterwegs pratikunterwegs marked this pull request as ready for review April 23, 2024 12:58
@pratikunterwegs pratikunterwegs merged commit ac85fa8 into main Apr 23, 2024
@pratikunterwegs pratikunterwegs deleted the dev-0.3.0 branch April 23, 2024 13:05
@pratikunterwegs pratikunterwegs mentioned this pull request Apr 23, 2024
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants