Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer blog previews in PR #51

Closed
wants to merge 2 commits into from
Closed

Offer blog previews in PR #51

wants to merge 2 commits into from

Conversation

pratikunterwegs
Copy link
Contributor

This is a draft PR that aims to fix #40 by adding a preview workflow from quarto-dev/quarto-web#667.

@pratikunterwegs pratikunterwegs added the enhancement New feature or request label May 4, 2023
@pratikunterwegs pratikunterwegs self-assigned this May 4, 2023
@pratikunterwegs
Copy link
Contributor Author

I've added the workflow file as-is from quarto-dev. Their workflow renders to Netlify, not GH pages - still working on that to check whether previewing on GH pages is possible.

@pratikunterwegs pratikunterwegs removed the request for review from Bisaloo May 4, 2023 07:29
@pratikunterwegs
Copy link
Contributor Author

pratikunterwegs commented Jul 18, 2023

Hi @Bisaloo, I've updated the preview workflow from the new version on quarto-web, but only Netlify previews are currently supported, per this (old) discussion on the quarto-cli repo.

If we have a Netlify account, could you add the credentials? I will rebase PR #76 with any updated credentials to check whether previews work correctly, and then delete it and the corresponding branch.

If not we might have to wait until GH Pages offers the same functionality, and I can mark the issue #40 as stale.

@Bisaloo Bisaloo mentioned this pull request Dec 11, 2023
@Bisaloo
Copy link
Member

Bisaloo commented Dec 11, 2023

Superseded by #156.

@Bisaloo Bisaloo closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer previews in PRs?
2 participants