Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mid year cleanup #212

Merged
merged 9 commits into from
Jun 12, 2024
Merged

Mid year cleanup #212

merged 9 commits into from
Jun 12, 2024

Conversation

pratikunterwegs
Copy link
Collaborator

This PR cleans up {finalsize} to prepare for a handover.

Copy link

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 49ff66c is merged into main:

  • ✔️complex_iterative: 540ms -> 541ms [-0.9%, +1.05%]
  • ✔️complex_newton: 648ms -> 650ms [-0.15%, +0.59%]
  • ✔️default_iterative: 511ms -> 512ms [-0.34%, +0.44%]
  • ✔️default_newton: 509ms -> 511ms [-0.03%, +0.95%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@pratikunterwegs pratikunterwegs marked this pull request as ready for review June 12, 2024 14:42
@pratikunterwegs
Copy link
Collaborator Author

Touchstone workflows fixed by #214, and all checks passing so merging this now.

@pratikunterwegs pratikunterwegs merged commit a78dcc3 into main Jun 12, 2024
13 checks passed
@pratikunterwegs pratikunterwegs deleted the dev-cleanup branch June 12, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants