Optional modules, qSim modules and qSim components configurations #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n steps Allows subclasses to register optional config groups to avoid writing many Run scripts.
|
Looks good! Let's merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users developping use cases and new modules to run new components without needing to write separate run scripts.
This is done by allowing subclassed of EqasimConfigurator to register optional elements (modules, qsim modules and qsim components configurations) that are activated only if related config groups are present.
The typical workflow for using this functionality is:
No tests for this functionality are added here as the next PR with DRT features will use it and all will be tested together.