Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing chrome software files #131

Closed
wants to merge 1 commit into from
Closed

Removing chrome software files #131

wants to merge 1 commit into from

Conversation

DT3264
Copy link
Collaborator

@DT3264 DT3264 commented Jun 25, 2023

Removing chrome software files

Since chrome is already replaced by chromium, I think is safe to remove it.

@DT3264
Copy link
Collaborator Author

DT3264 commented Aug 2, 2023

@equetzal This PR is now independent from any other PR referenced

Are those files still in use?

@DT3264 DT3264 changed the title Removing uneeded files Updating software files Aug 2, 2023
@DT3264
Copy link
Collaborator Author

DT3264 commented Aug 2, 2023

@equetzal This PR is now independent from any other PR referenced

Wdyt on this particular change?

Or shall it be split in multiple PRs one for each program? 🤔

@equetzal
Copy link
Owner

equetzal commented Aug 2, 2023

@equetzal This PR is now independent from any other PR referenced

Wdyt on this particular change?

Or shall it be split in multiple PRs one for each program? 🤔

You can leave the PR with all the changes, but in overall think of atomic PRs. If you ned to write "and" probably you need to split the PR.

About the code, I like the idea, but make sure to delete the sources.list from the final .hsm; we don't want to have overlay of sources.list over any other sources.list we've on lower layers.
e.g. If we add deb.huronos.org to the sources list and want to reuse a module that already have an old sources.list + the external repo, then with AUFS the new sources.list will be opaqued by the software modules.

Since chrome is already replaced by chromium, I think is safe to remove it.
@DT3264 DT3264 changed the title Updating software files Removing chrome software files Aug 3, 2023
@DT3264
Copy link
Collaborator Author

DT3264 commented Aug 3, 2023

@equetzal Closing this PR because after splitting, the first PR started as a new one, we can keep the conversation around #165 through #168

I also added the line to remove the /etc/apt/sources.list on each PR

@DT3264 DT3264 closed this Aug 3, 2023
@DT3264 DT3264 deleted the pr131 branch October 12, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants