This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
[Fix][Sherlock M-3 + M-13] Handle position rebalance 0 value cases #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrizzle
reviewed
Jul 27, 2023
| product.closeMake(accountPosition.sub(targetPosition).min(makerAvailable)); | ||
| // If there is no maker available (socialization), we still need a settlement but closing 0 value will revert, | ||
| // so instead open 0 value instead | ||
| if (makerAvailable.isZero()) product.openMake(makerAvailable); |
There was a problem hiding this comment.
can you do product.openMake(UFixed18Lib.ZERO); here also so it's consistent
kbrizzle
reviewed
Jul 28, 2023
arjun-io
force-pushed
the
arjun/fix-position-rebalance
branch
from
c6181b7
to
ee909cd
Compare
Integration Test Coverage ReportCoverage after merging arjun/fix-position-rebalance into dev2 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
kbrizzle
approved these changes
Aug 7, 2023
kbrizzle
reviewed
Aug 7, 2023
|
|
||
| if (targetPosition.lt(currentPosition)) | ||
| product.closeMake(currentPosition.sub(targetPosition)); | ||
| if (targetPosition.gte(currentPosition)) | ||
| product.openMake(targetPosition.sub(currentPosition).min(makerAvailable)); | ||
| else if (targetPosition.gt(currentPosition)) { |
There was a problem hiding this comment.
if (targetPosition.lt(currentPosition))
product.closeMake(currentPosition.sub(targetPosition));
if (targetPosition.gt(currentPosition))
product.openMake(targetPosition.sub(currentPosition).min(makerAvailable));
if (targetPosition.eq(currentPosition))
product.closeMake(UFixed18Lib.ZERO);
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the following logic to both vault versions:
Also introduces a utilization check to the SingleBalancedVault
Adds tests