Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add labels to off page connectors #18

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Add labels to off page connectors #18

merged 4 commits into from
Oct 9, 2024

Conversation

JohannesETelle
Copy link
Contributor

No description provided.

@JohannesETelle JohannesETelle marked this pull request as draft October 4, 2024 08:37
@JohannesETelle JohannesETelle marked this pull request as ready for review October 9, 2024 06:40
henriettelienrebnor
henriettelienrebnor approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@henriettelienrebnor henriettelienrebnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Did not realise that the off page connectors were under piping components, I therefore forgot the labels when redoing the mappings for the symbol lib.

@henriettelienrebnor henriettelienrebnor merged commit b7ba6de into main Oct 9, 2024
1 check passed
@henriettelienrebnor henriettelienrebnor deleted the story181785/Off-page-connectors-labels-missing branch October 10, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henriettelienrebnor henriettelienrebnor henriettelienrebnor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohannesETelle @henriettelienrebnor