-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Story 188083: Multiple commissioning packages #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoye
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!🤩 the code is very clear and well structured, very good job!
We discussed these points in person, but just writing them here to remember!
- Add the possibility for zooming in
- Update the README
- Add a undo button
- Add table / excel downloads in separate tab from the side menu
- Use Equinor font
- Add possibility to delete packages
- Avoid that everything is deleted on refresh of the page
- Make the clickable area larger on lines and symbols
- Change line thickness on symbols/lines which are chosen as boundaries so that they are easier to see
henriettelienrebnor
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#188083
Aim of the PR
One of the sprint goals is to implement functionality for creating multiple commissioning packages in one P&ID. This PR aims to complete this sprint goal and add all necessary supporting functionality.
Implementation
A lot has been changed in this PR. Some diffs are only from moving components to new folders (see Additional Changes).
Context
The context has been changed, so that everything related to commissioning packages is stored in one context, and each commissioning package contains information on all the nodes in it. This way, it's easier to check which package an ID belongs to.
We also have a new context containing information on the currently active tool.
Sidebar
A new sidebar has been created. The sidebar contains tools for selecting boundaries and internals, plus a button for creating a new commissioning package, and a dropdown to select active package.
There is also a new TopBar that shows the currently active commissioning package.
Creating a new commissioning package
You can now create new packages by clicking the + icon in the sidebar. The ID will, for now, automatically be prefixed with "asset:". There is no hard validation on the id, but the border around the id will be orange if it contains something other than a-z, 0-9 and -. Each commissioning package has a highlight color.
Creating multiple commissioning packages
Like before, you have an initial package which you can add boundaries and internals to. Then, you can create a new package, and select other boundaries and internals for that package. You should now see two different commissioning packages.
IRI
An attempt has been made to port the IRI creation for CenterLines from the XSLT. There are some issues with placement (e.g knowing if something is preceding or next sibling) This means that you cannot reliably select pipes as boundaries or internals, because the IRI might be wrong.
Known issues
While I have attempted to not allow the user to select components which are already in another package, there is nothing to stop the user from just selecting an internal with no borders. Take this scenario:
For now, this is difficult to fix, would require some automatic boundary creation. Probably not worth spending time on until new format is ready.
Type of change
How Has This Been Tested?
Tested by logging which completion packages contain which elements, and checking that they don't contain too many elements.
Manual testing in browser of functionality:
Additional Changes