Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story/204309 graphical rdf #56

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Story/204309 graphical rdf #56

merged 6 commits into from
Dec 20, 2024

Conversation

markus-ap
Copy link
Contributor

@markus-ap markus-ap commented Dec 19, 2024

Pull requests practices for the SSI team

Aim of the PR

This PR fixes AB#204309

This PR aims to add examples regarding how the graphical format of DEXPI looks in RDF.

Implementation

Please provide an overview of how this change achieves the goal.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • This change requires a documentation update
  • Documentation

If the changes impact any dependent services then provide details.

Additional Changes

Creation of separate JSON example for the frontend-spec put into the examples folder.

@markus-ap markus-ap requested a review from daghovland December 19, 2024 13:43
@markus-ap
Copy link
Contributor Author

markus-ap commented Dec 19, 2024

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

Copy link
Contributor

@daghovland daghovland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeg tenker dette må være et veldig bra start-punkt, også lærer vi sikkert mer når vi lager mappinger og ontologi. Det ser jo veldig greit ut, og bortsett fra navnerom kanskje allerede klart til bruk? Jeg har ingen gode forslag til navnerom. To ting jeg oppdaget når jeg lastet inn i RDFox:

  • Custom datatyper er ikke støttet per default, men kan settes til å bli en string. Jeg synes likevel det er en god ide å ha dem, men det er en catch.
  • xsd prefikset er ikke definert i graphical.trig, men finnes jo i de fleste verktøy. Du kan vurdere å legge til @Prefix xsd: http://www.w3.org/2001/XMLSchema# .

@markus-ap markus-ap merged commit dbfa51b into main Dec 20, 2024
5 checks passed
@markus-ap markus-ap deleted the story/204309-graphical-rdf branch December 20, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants