.

github-action/src/utils/makeManifest.ts

@@ -5,16 +5,10 @@ import { notice } from '@actions/core';
 export function makeManifest(path: string) {
   // Create manifest
   notice('making manifest');
-  const { version, name, ...maybe } = parsePackageJson(path);
+  const { version, name } = parsePackageJson(path);
   if (!version || !name) {
     throw new Error('Name or version missing in package.json');
   }
-  const { major, minor, patch } = splitVersions(version);
-
-  /** Some app-manifests have custom short and displaynames */
-  const shortName = maybe?.['shortName'] ?? name;
-  const displayName = maybe?.['displayName'] ?? name[0].toUpperCase() + name.slice(1);
-
   const manifest = {
     //required
     entryPoint: "app-bundle.js",
@@ -31,11 +25,3 @@ export function makeManifest(path: string) {
   fs.writeFileSync('./dist/app-manifest.json', data);
 }
 
-function splitVersions(version: string) {
-  const [major, minor, patch] = version.split('.');
-  return {
-    major,
-    minor,
-    patch,
-  };
-}

github-action/src/utils/uploadBundle.ts

@@ -32,7 +32,7 @@ export async function uploadBundle(
   );
 
   notice(`bundle uploaded with status code ${r.message.statusCode}`);
-  if (r.message.statusCode !== 200) {
+  if (r.message.statusCode !== 201) {
     const body = await r.readBody()
     logInfo(`Failed to upload ${appKey}, code: ${r.message.statusCode}`, 'Red');
     logInfo(body, 'Red');