Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 [handover] : Enable 3D in sidesheet #940

Closed
Tracked by #578
kjellhaaland opened this issue Apr 11, 2024 · 8 comments
Closed
Tracked by #578

🎁 [handover] : Enable 3D in sidesheet #940

kjellhaaland opened this issue Apr 11, 2024 · 8 comments
Assignees

Comments

@kjellhaaland
Copy link
Contributor

kjellhaaland commented Apr 11, 2024

The baseline 3D Model-viewer component is finished, and available for use in all cc-applications.
Implemented in PR #774

To use it in the rest of the applications, the following needs to be done:

  1. Create a new endpoint in each of the apps returning the relevant tags for a given entity. (/echo endpoint, see work-order implementation)
  2. Enable the model-viewer in application config.
  3. Add the ModelViewerTab to each sidesheet with relevant props.

In order to implement this, PO must provide a list of which types of tags that are relevant for 3D for each application.

@kjellhaaland kjellhaaland added the question Further information is requested label Apr 11, 2024
@kjellhaaland
Copy link
Contributor Author

@jone, which tags are relevant for 3D for this application?

@atlewee
Copy link

atlewee commented Apr 11, 2024

All tags in the selected commPk.
completionTag.commissioningPackageId == selectedCommPk.sourceIdentity :)

@kjellhaaland
Copy link
Contributor Author

Implementation note:

API endpoint for fetching tags relevant for Handover uses CompletionTagV3, and fetches all tags with a matching commissioningPackageId matching the commissioningPackageId of the Handover.

@kjellhaaland
Copy link
Contributor Author

@JoneUE
Copy link
Contributor

JoneUE commented Apr 18, 2024

image
Where is the 3D tab?

@JoneUE
Copy link
Contributor

JoneUE commented Apr 18, 2024

Do you know if you get any matches in the model by using the CompletionRegister endpoint. This has all the dummyTags

@atlewee
Copy link

atlewee commented Apr 18, 2024

Info: There is no dummy-Tags in the 3D model, so wont be any match on those.

@kjellhaaland
Copy link
Contributor Author

kjellhaaland commented Apr 22, 2024

3D for Handover is now deployed to production.
Closing this issue 🎉

FYI @JoneUE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants